Skip to content
Nick Ruest edited this page Jan 4, 2017 · 8 revisions

Time/Place

This meeting is a hybrid teleconference and IRC chat. Anyone is welcome to join. Here is the info:

Attendees

  • Nick Ruest
  • Amanda Lehan
  • Marcus Barnes
  • Don Richards
  • Natkeeran Ledchumykanthan
  • Diego Pino
  • Ed Fugikawa
  • Kim Pham ⭐
  • Bryan Brown
  • Danny Lamb
  • Melissa Anez
  • Jonathan Green

Agenda

  1. Break apart github repos for islandora modules
  2. ... (feel free to add agenda items)

Minutes

  • Danny: tried to use extension for stomp-php module, found that it does not work with php 7. Used php client, use composer to pull it in. If we want to use Composer for our packages, github doesn't like this. one package available. Proposal to break apart all islandora modules into separate repositories.
  • Danny: Each module declares its own dependencies but biggest issue is how to distribute them indivually, separate from one another. How to distribute as its own package that you would require. Get one but not necessarily all of the others, can't do this until you separate them into different git repositories. Do this early now before we start tacking on other islandora components.
  • Nick: Concern over proliferation of modules and to have them not get out of hand.
    • Don't think we will have as many modules, contribution will be a similar but different process.
  • Nick: One of the early things we said is that there'd just be one Drupal module. One module, submodules promised early, but may not be the best approach
  • Diego: Right now there's 3 modules, Islandora and islandora collection, json-ld. We can have a composer json for each and have a method to merge composer json with main composer json and then run that. Issue is that composer is a good tool to load external libraries, but it's based on the idea that everything inside your directory structure belongs to one project. Not good handling mutliple composers in different parts. root and composer json, doesn't care about other composer json files. Splitting is a good idea but we need a helper function to join all composer json files together and running that as per danny's add on suggestion. there are however other ways of doing this. the question is if we stick to one islandora repo having multiple modules is this OK?
    • Danny: Difficult once we get beyond the 3 we already have. We'll inevitably do this so might as well we do it now
  • Diego: it's hackish, to tell files to merge. we need to make structural and installation changes. Hackish because not using the composer json, using what's inside then combining into main directory. publish into main drupal 8 vendor. no other known projects do this. it's not drupal vanilla composer. will need to add special plugin to go in and extract requirements.
  • Danny: We can edit composer json with some scripts, separate core from contrib then add a bit that says this part of drupal.org is a packages repo. You do have to define dependencies in module in your site's composer.json. Once in git repo modules define then goes in a sitewide vendor file. Similar to rails or bundler.
  • Diego: i wonder how will people keep sync of other modules. Once you go composer way, they will need to modify their composer.json (the one we provide)
  • Danny: the idea is that you would commit your own institutions composer.json to a github repo. once you set your dependencies and install, it's yours
  • Diego: It's yours, until you update. update drupal, or update islandora.So we need to document carefully also this stuff

Link examples:

  • Nick: Asked CLAW group if anyone has a strong objection to Danny's proposal.
    • No major objections from the group in the CLAW call about this approach
  • Jonathan Green: the way git looks is the way packages should look. more work packaging and release mgr. with some automation it is possible to do that. try to make things easier for people
  • Danny, Melissa: Fine to bring this up in Roadmap this Friday

This is an archive. For new Tech Call notes, click here

⚠️ ARCHIVED Islandora Tech Calls

⚠️ ARCHIVED Islandora User Calls

Clone this wiki locally