feat: use ogp design system #7308
Conversation
not v9 for now since lots of breaking changes plugin prettier also v4 for now, v5 breaks due to
since we are still on CRA4
# Conflicts: # .eslintrc
so react-email templates has no type errors when rendering on the server
v2 requires more changes, not worth it for now
actually good to snapshot full page instead of just fixed pages
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
that have been converted to use ogpds components instead
design doesn't have the colors yet
|
@karrui Hi, i was trying to incorporate the ogp design system's Attachment component for #7339 however I think that the current Attachment component is an overkill for the above mentioned issue. One suggestion I have is to make some changes to the ogp design system's Attachment component to allow customisation of size (for example to include height and width props). What do you think?
|
Don't think that needs to be in the design system explicitly, since expected behaviour is pretty specific to FormSG (drag and drop the file, then set the file content as an input). I think we could just wrap the current file input with some drag event handlers to read the file contents and set the input instead. |
KenLSM
force-pushed
the
04-30-feat_upgrade_typescript_to_5.4.5_across_app
branch
from
6f20922
to
cacf238
Compare
KenLSM
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
10 times, most recently
from
7fba8d0
to
dabcfa1
Compare
Problem
Closes [insert issue #]
Solution
Breaking Changes
Features:
Improvements:
Bug Fixes:
Before & After Screenshots
BEFORE:
AFTER:
Tests
Deploy Notes
New environment variables:
env var: env var detailsNew scripts:
script: script detailsNew dependencies:
dependency: dependency detailsNew dev dependencies:
dependency: dependency details