-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update eslint packages to stable latest versions #7277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oops missed one package |
karrui
force-pushed
the
upgrade-eslint-and-prettier
branch
from
April 23, 2024 07:51
86ceffb
to
8c1559d
Compare
All the ignored lint errors.... out of scope of this PR though... might fix those in a previous PR then T_T |
karrui
force-pushed
the
upgrade-eslint-and-prettier
branch
from
April 24, 2024 07:56
577700b
to
4db5926
Compare
This was referenced Apr 24, 2024
justynoh
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
not v9 for now since lots of breaking changes plugin prettier also v4 for now, v5 breaks due to
since we are still on CRA4
# Conflicts: # .eslintrc
karrui
force-pushed
the
upgrade-eslint-and-prettier
branch
from
May 2, 2024 04:34
4db5926
to
4ffd43f
Compare
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint very outdated. Time to fix it. Part of my package upgrading spree. Plan of action: