feat: migrate from CRA4 to Vite, Storybook to v8, jest to Vitest #7285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2024
karrui
changed the title
|
@KenLSM see chromatic useful. will ensure the migration has 0 frontend changes!!! |
karrui
changed the title
karrui
changed the title
|
@justynoh this PR officially has no regressions hehehehe |
|
@justynoh added datadog chunking back to the pipeline. Can push to staging to try? |
karrui
force-pushed
the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
from
0a96443
to
9f75cd7
Compare
karrui
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
from
2c7a9e4
to
9177241
Compare
karrui
commented
May 2, 2024
karrui
commented
May 2, 2024
karrui
commented
May 2, 2024
Base automatically changed from
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
to
04-23-feat_upgrade_prettier_to_v3
May 15, 2024 12:34
KenLSM
approved these changes
Jun 11, 2024
…tial_vite_config_and_new_eslint_rules # Conflicts: # frontend/.storybook/main.js # frontend/package-lock.json # frontend/package.json # frontend/src/components/Field/Attachment/Attachment.tsx # frontend/src/components/Searchbar/Searchbar.stories.tsx # frontend/src/features/admin-form/create/builder-and-design/BuilderAndDesignDrawer/FieldListDrawer/field-panels/MyInfoPanel.tsx # frontend/src/features/admin-form/share/ShareFormModal.tsx # frontend/src/features/public-form/PublicFormContext.tsx # frontend/src/hooks/useMdComponents.tsx # playwright.config.ts # shared/constants/form.ts
…tial_vite_config_and_new_eslint_rules # Conflicts: # frontend/.storybook/main.js
KenLSM
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
7 times, most recently
from
f3f55e9
to
1754bee
Compare
KenLSM
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
from
1754bee
to
2998079
Compare
2 tasks
KenLSM
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
from
62311bd
to
e06fa47
Compare
KenLSM
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
2 times, most recently
from
1d546e2
to
7fba8d0
Compare
KenLSM
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
from
7fba8d0
to
dabcfa1
Compare
KenLSM
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
from
88d0aaf
to
4561bf8
Compare
KenLSM
reviewed
Sep 18, 2024
| @@ -8,6 +8,8 @@ | |||
| "jszip": "^3.7.1", | |||
| "libphonenumber-js": "^1.10.48", | |||
| "lodash": "^4.17.21", | |||
| "tweetnacl": "^1.0.3", | |||
| "tweetnacl-util": "^0.15.1", | |||
There was a problem hiding this comment.
@kevin9foong btw we forgot to add these two packages in to /shared 💀.
Finally solved final piece of why chromatic publishing fails when using vite/rollup. webpack is a little looser in resolving imports thus we didn't notice it while rollup/pnpm are much stricter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the frontend toolchain from CRA4 to Vite.
Generally everything seems to be working fine, including decryption workers.
Requires a bunch of changes that has to be performed all at the same time:
TODO: