-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to react 18 and chakra v2 #7292
feat: upgrade to react 18 and chakra v2 #7292
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
46b2d11
to
3351110
Compare
almost there, all the regressions are hopefully caught by frontend tests. thanks @opengovsg/formsg-engineers for the upkeep of tests! it's coming in super handy now :) |
Daaaaaang, great upgrades FTW @karrui 💪 !! What noticeable improvements from the upgrade can the team expect, and should be monitored? |
ecbc1d6
to
72d78b4
Compare
I think improvements are not noticeable to the public haha. This one just foundation to allow FormSG to use OGPDS (and not have upgrade path to react 19 get blocked when that comes out this year) Developer experience wise, should be must faster to start up. Tests also run faster. |
2c7a9e4
to
9177241
Compare
72d78b4
to
8e5511e
Compare
2856457
to
f2a558a
Compare
react v17 -> react v18 chakra v1 -> chakra v2
new implementation doesn't work lol
really need to go to OGPDS soon lol
instead of following button's height
so the border won't look janky
f663c06
to
6d16f3c
Compare
2db7cf4
into
04-23-feat_add_initial_vite_config_and_new_eslint_rules
This PR upgrades React from React 17 to React 18, as well as ChakraUI v1 to v2. This is necessary due to ChakraUI V2 only being compatible with React 18.
In addition, a bunch of packages are upgraded too to allow for compatibility with React 18.
list of changed deps required to make the app work lol:
refrained from upgrading some packages that are not super required, will do it in later PRs.
This includes:
@tanstack/react-query
react-hook-form, etc