-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade typescript to 5.4.5 across app #7305
Merged
KenLSM
merged 66 commits into
04-23-feat_add_initial_vite_config_and_new_eslint_rules
from
04-30-feat_upgrade_typescript_to_5.4.5_across_app
Jul 30, 2024
Merged
feat: upgrade typescript to 5.4.5 across app #7305
KenLSM
merged 66 commits into
04-23-feat_add_initial_vite_config_and_new_eslint_rules
from
04-30-feat_upgrade_typescript_to_5.4.5_across_app
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2024
karrui
force-pushed
the
04-30-feat_upgrade_typescript_to_5.4.5_across_app
branch
from
May 2, 2024 04:42
7cd20fd
to
6f20922
Compare
deployed with no issuessssssssss!!!!# |
KenLSM
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMMMM
react v17 -> react v18 chakra v1 -> chakra v2
new implementation doesn't work lol
really need to go to OGPDS soon lol
instead of following button's height
so the border won't look janky
KenLSM
force-pushed
the
04-26-feat_upgrade_react_and_chakra-ui_react_v17_-_react_v18_chakra_v1_-_chakra_v2
branch
from
June 11, 2024 14:58
f663c06
to
6d16f3c
Compare
KenLSM
force-pushed
the
04-30-feat_upgrade_typescript_to_5.4.5_across_app
branch
from
June 11, 2024 15:39
6f20922
to
cacf238
Compare
Base automatically changed from
04-26-feat_upgrade_react_and_chakra-ui_react_v17_-_react_v18_chakra_v1_-_chakra_v2
to
04-23-feat_add_initial_vite_config_and_new_eslint_rules
July 30, 2024 03:33
…' into 04-30-feat_upgrade_typescript_to_5.4.5_across_app
KenLSM
merged commit Jul 30, 2024
1345be1
into
04-23-feat_add_initial_vite_config_and_new_eslint_rules
5 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the TypeScript version from 4.9.4 to 5.4.5 across the app.
Fix (or ignoreeee) all type errors uncaught in previous runs.