Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce subcommands in a backwards-compatible way #1073

Merged
merged 50 commits into from
Sep 6, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jun 21, 2022

This pull request renames all the commands in a backwards-compatible way, and closes #762.

Functionality remains unchanged, and the only difference is that cml <balderdash> can also be called by using cml <noun> <verb> as suggested.

Dependencies

Follow-up issues

Outstanding1 unresolved discussions

Footnotes

  1. As per https://github.com/iterative/cml/pull/1073#issuecomment-1224095678, there might be some threads that were marked as resolved but no action was taken to address they suggestions they include. Feel free to take a look.

@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request technical-debt Refactoring, linting & tidying ui/ux User interface/experience labels Jun 21, 2022
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jun 21, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 21, 2022 15:34 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 21, 2022 15:37 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 21, 2022 15:38 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 21, 2022 15:43 Inactive
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review June 21, 2022 15:47
@0x2b3bfa0 0x2b3bfa0 requested a review from a team June 21, 2022 16:13
@dacbd
Copy link
Contributor

dacbd commented Jun 21, 2022

Would cml ci forever live in legacy mode?

@0x2b3bfa0
Copy link
Member Author

I was toying with the idea of using cml repository configure 😅

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 21, 2022 21:59 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 22, 2022 16:25 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 22, 2022 16:53 Inactive
@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Jun 22, 2022

🔔 @iterative/cml, ready for a first round of feedback?

For now, the only breaking change (as per our last meeting) is that calling cml runner with no arguments prints the help message instead of launching a local runner.

The rest of commands are backwards compatible ad nauseam and behave exactly as they did in the past, thanks to a fair amount of yargs surgery. 🤢

Reading the pull request changes is rather cumbersome. Given that tests haven't changed and are still passing,1 I would recommend to npm install --global github:iterative/cml#command-naming-consistency and explore the new commands as users would do.

Footnotes

  1. For what they're worth, of course.

Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P.S. we don't need rerun-workflow backward compat because 'twas never documented/released :P

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal June 23, 2022 22:05 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 5, 2022 22:03 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 6, 2022 02:38 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 6, 2022 02:50 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 6, 2022 22:45 Inactive
@casperdcl casperdcl merged commit 341f32e into master Sep 6, 2022
@casperdcl casperdcl deleted the command-naming-consistency branch September 6, 2022 23:15
@casperdcl
Copy link
Contributor

Gratias @0x2b3bfa0!

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Sep 6, 2022

Nihil est, @casperdcl! ⚔️ 🤝

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Sep 6, 2022

Next steps

  • @iterative/cml, please make sure that you're happy with the result
  • @iterative/scapegoat, please open follow-up issues for the items listed in the pull request body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request technical-debt Refactoring, linting & tidying ui/ux User interface/experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command naming consistency
7 participants