Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --publish & --watch options to cml check create #1143

Open
Tracked by #1073
0x2b3bfa0 opened this issue Sep 7, 2022 · 3 comments
Open
Tracked by #1073

Add --publish & --watch options to cml check create #1143

0x2b3bfa0 opened this issue Sep 7, 2022 · 3 comments

Comments

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Sep 7, 2022

As per #1073 (comment), cml check create should include the --publish and --watch options already present in the cml comment <verb> commands.

@0x2b3bfa0
Copy link
Member Author

Not sure about the cml check create --watch option. Are checks mutable by definition? 🤔

@dacbd
Copy link
Contributor

dacbd commented Sep 9, 2022

I agree that I don't think a --watch option makes sense. You might update a check's status throughout your workflow if the ci API's allow, but the "content" is only set at the end when you know the definitive state of said check /right?

@0x2b3bfa0
Copy link
Member Author

Yes, that was my impression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants