Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and warn for timeout-minutes change #1098

Closed
wants to merge 21 commits into from
Closed

Detect and warn for timeout-minutes change #1098

wants to merge 21 commits into from

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Jul 21, 2022 •
edited
Loading

+/- Provides a paradigm for other checks/warnings in the future

  • Debatably overly complicated detection of relevant timeout-minutes

Sample of warning:
image

Example of detection:
image

Same file, an example of non-detection:
image

@dacbd dacbd temporarily deployed to internal July 21, 2022 00:44 Inactive
@dacbd dacbd temporarily deployed to internal July 21, 2022 00:58 Inactive
dacbd added a commit to iterative/cml-playground that referenced this pull request Jul 21, 2022
@dacbd
add iterative/cml#1098 test/example
359ccfe
dacbd added a commit to iterative/cml-playground that referenced this pull request Jul 21, 2022
@dacbd
add iterative/cml#1098 test/example
f914d89
@dacbd dacbd temporarily deployed to internal July 21, 2022 01:36 Inactive
@dacbd dacbd temporarily deployed to internal July 21, 2022 02:23 Inactive
DavidGOrtega
DavidGOrtega suggested changes Jul 21, 2022
View reviewed changes
src/drivers/github.js Outdated Show resolved Hide resolved
@dacbd dacbd temporarily deployed to internal July 22, 2022 18:38 Inactive
@dacbd dacbd temporarily deployed to internal July 22, 2022 18:43 Inactive
@dacbd dacbd temporarily deployed to internal July 22, 2022 19:09 Inactive
@dacbd dacbd temporarily deployed to internal July 22, 2022 19:26 Inactive
@dacbd dacbd added technical-debt Refactoring, linting & tidying cml-runner Subcommand ci-github labels Jul 22, 2022
@dacbd dacbd marked this pull request as ready for review July 22, 2022 19:41
@0x2b3bfa0
Copy link
Member

At this point I think its best for this to wait for the command renaming pr

@0x2b3bfa0
Copy link
Member

@dacbd, it looks like you'll have to rebase things a bit after #1073

@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Oct 6, 2022
Open
@0x2b3bfa0 0x2b3bfa0 force-pushed the master branch 3 times, most recently from e2bed3a to fe9a06f Compare October 8, 2022 04:28
@dacbd dacbd closed this Oct 8, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the detect-actions-timeout branch October 14, 2022 23:42
@0x2b3bfa0 0x2b3bfa0 restored the detect-actions-timeout branch October 14, 2022 23:42
@0x2b3bfa0 0x2b3bfa0 deleted the detect-actions-timeout branch June 4, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 left review comments

@DavidGOrtega DavidGOrtega DavidGOrtega approved these changes

@casperdcl casperdcl Awaiting requested review from casperdcl

Assignees

@dacbd dacbd

Labels
ci-github cml-runner Subcommand technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dacbd @DavidGOrtega @0x2b3bfa0 @casperdcl