Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide cml comment <verb> --rm-watermark option #1140

Closed
Tracked by #1073
0x2b3bfa0 opened this issue Sep 7, 2022 · 3 comments · Fixed by #1235
Closed
Tracked by #1073

Hide cml comment <verb> --rm-watermark option #1140

0x2b3bfa0 opened this issue Sep 7, 2022 · 3 comments · Fixed by #1235
Labels
cml-comment Subcommand external-request You asked, we did good-first-issue Good for newcomers (good-first-issue) p2-nice-to-have Low priority technical-debt Refactoring, linting & tidying

Comments

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Sep 7, 2022 •
edited by dacbd
Loading

As per #1073 (comment), the --rm-watermark option should be removed, or at least, hidden. Watermarks (#1076) are crucial for the proper operation of cml comment update and an option to disable them has no(little) practical use case.
@0x2b3bfa0 0x2b3bfa0 mentioned this issue Sep 7, 2022
Merged
9 tasks
@deepyaman deepyaman mentioned this issue Oct 24, 2022
Merged
@deepyaman
Copy link
Contributor

@0x2b3bfa0 Should --rm-watermark be hidden on other commands, too (i.e. tensorboard connect, asset publish)?

@0x2b3bfa0
Copy link
Member Author

On all the commands it appears, preferably

@casperdcl casperdcl added good-first-issue Good for newcomers (good-first-issue) external-request You asked, we did technical-debt Refactoring, linting & tidying cml-comment Subcommand p2-nice-to-have Low priority labels Oct 25, 2022
@deepyaman
Copy link
Contributor

On all the commands it appears, preferably

Was waiting for the CI to run so I could fix the formatting, but I think it should be good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cml-comment Subcommand external-request You asked, we did good-first-issue Good for newcomers (good-first-issue) p2-nice-to-have Low priority technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide --rm-watermark option when invoking CML CLI deepyaman/cml
3 participants
@casperdcl @0x2b3bfa0 @deepyaman