chore(tier4_perception_launch): enable to receive argument centerpoint_model_name from autoware_launch
#9003
+20
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MasatoSaeki <[email protected]>
github-actions
bot
added
the
component:launch
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4 tasks
Signed-off-by: MasatoSaeki <[email protected]>
MasatoSaeki
requested review from
miursh,
technolojin,
YoshiRi and
yukkysaito
as code owners
MasatoSaeki
added
the
tag:run-build-and-test-differential
technolojin
reviewed
Oct 3, 2024
| @@ -37,9 +37,13 @@ | |||
| <arg name="traffic_light_arbiter_param_path"/> | |||
|
|
|||
| <!-- CenterPoint model parameters --> | |||
| <arg name="centerpoint_model_name" default="centerpoint_tiny" description="options: `centerpoint`, `centerpoint_tiny` or `centerpoint_sigma`"/> | |||
| <arg name="centerpoint_model_name" default="$(var centerpoint_model_name)"/> | |||
There was a problem hiding this comment.
Suggested change
| <arg name="centerpoint_model_name" default="$(var centerpoint_model_name)"/> | |
| <arg name="centerpoint_model_name"/> |
technolojin
reviewed
Oct 3, 2024
| <arg name="centerpoint_model_path" default="$(var data_path)/lidar_centerpoint"/> | ||
|
|
||
| <!-- CenterPoint model parameters --> | ||
| <arg name="transfusion_model_name" default="$(var transfusion_model_name)"/> |
There was a problem hiding this comment.
Suggested change
| <arg name="transfusion_model_name" default="$(var transfusion_model_name)"/> | |
| <arg name="transfusion_model_name"/> |
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Signed-off-by: MasatoSaeki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enable to receive argument
centerpoint_model_namefromautoware_launch.This PR need to merge following autoware_launch PR at same time.
centerpoint_model_nameautoware_launch#1182Related links
Parent Issue:
How was this PR tested?
I have checked it work correctory by sample rosbag in my local pc.
And also checked whether it can change model. (A part of model is failed but it is no problem because it depend on another repos.)
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.