-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(compiler): type references as expressions and phase tracking #3177
Merged
Merged
Changes from 11 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
71a51ff
chore: add `phase` to each expression during type checking
eladb e9f2b5d
left overs
eladb 59b72d3
chore: self mutation
monadabot 460f633
Type references
eladb 74de1b7
fix(cli): `wing test` returns 0 exit code upon failure (#3176)
eladb 7394012
merge
eladb a289ac2
Merge remote-tracking branch 'origin/main' into eladb/add-phase-to-ty…
eladb 84933db
remove stale files from previous lift
eladb fa903ff
fix invalid logic
eladb 6fcd257
tweaks
eladb 78226b5
oops
eladb 899bbaa
add test `inflight_reassign` and fix errors
eladb 4cae383
update snaps
eladb 06dee2f
chore: self mutation
monadabot af789dc
chore: self mutation
monadabot 96cc4b8
Update libs/wingc/src/type_check.rs
eladb db3bafc
Update libs/wingc/src/type_check.rs
eladb c81c979
Merge branch 'main' into eladb/add-phase-to-typecheck
eladb 7113d6f
fix diagnostics of base classes
eladb db6718e
restore enum test and update snaps
eladb 5055f82
Merge branch 'main' into eladb/add-phase-to-typecheck
eladb 7d9a7d2
fix parser
eladb 5b91ea5
chore: self mutation
monadabot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
class Foo { } | ||
|
||
let foo1 = new Foo(); | ||
let bar2 = new Foo() as "bar2"; | ||
|
||
assert(foo1.node.id == "Foo"); | ||
assert(bar2.node.id == "bar2"); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that commented out on purpose?