Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(compiler): type references as expressions and phase tracking #3177

Merged
merged 23 commits into from
Jun 30, 2023
Merged

chore(compiler): type references as expressions and phase tracking #3177

merged 23 commits into from
Jun 30, 2023

Commits on Jun 30, 2023

  1. chore: add phase to each expression during type checking 

    No functional changes, preparatory pull request as part of the expression lifting escapade.

To support expression lifting, the type checker now records the phase of each expression during type checking and makes it available through `get_expr_phase`.

Additionally, turn the variable component of `StmtKind::Assignment` from a simple `Symbol` to an `Expr` in order for it to also hold type and phase information.

The JSII importer accidentally imported structs as `preflight` while they should be phase-independent.

Misc: strip excess newlines when adding a line to `CodeMaker`.
    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    71a51ff View commit details
    Browse the repository at this point in the history

  2. left overs

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    e9f2b5d View commit details
    Browse the repository at this point in the history

  3. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    59b72d3 View commit details
    Browse the repository at this point in the history

  4. Type references

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    460f633 View commit details
    Browse the repository at this point in the history

  5. fix(cli): wing test returns 0 exit code upon failure (#3176) 

    Fixes #2916 by returning exit code 0 when tests fail.

## Misc

Tweaks to a bunch of tests.

## Checklist

- [x] Title matches [Winglang's style guide](https://docs.winglang.io/contributing/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [x] Docs updated (only required for features)
- [x] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://docs.winglang.io/terms-and-policies/contribution-license.html)*.
    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    74de1b7 View commit details
    Browse the repository at this point in the history

  6. merge

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    7394012 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into eladb/add-phase-to-ty… 

    …pecheck
    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    a289ac2 View commit details
    Browse the repository at this point in the history

  8. remove stale files from previous lift

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    84933db View commit details
    Browse the repository at this point in the history

  9. fix invalid logic

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    fa903ff View commit details
    Browse the repository at this point in the history

  10. tweaks

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    6fcd257 View commit details
    Browse the repository at this point in the history

  11. oops

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    78226b5 View commit details
    Browse the repository at this point in the history

  12. add test inflight_reassign and fix errors

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    899bbaa View commit details
    Browse the repository at this point in the history

  13. update snaps

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    4cae383 View commit details
    Browse the repository at this point in the history

  14. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    06dee2f View commit details
    Browse the repository at this point in the history

  15. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    af789dc View commit details
    Browse the repository at this point in the history

  16. Update libs/wingc/src/type_check.rs 

    Co-authored-by: Chris Rybicki <[email protected]>
    @eladb @Chriscbr
    eladb and Chriscbr committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    96cc4b8 View commit details
    Browse the repository at this point in the history

  17. Update libs/wingc/src/type_check.rs 

    Co-authored-by: Chris Rybicki <[email protected]>
    @eladb @Chriscbr
    eladb and Chriscbr committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    db3bafc View commit details
    Browse the repository at this point in the history

  18. Merge branch 'main' into eladb/add-phase-to-typecheck

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    c81c979 View commit details
    Browse the repository at this point in the history

  19. fix diagnostics of base classes

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    7113d6f View commit details
    Browse the repository at this point in the history

  20. restore enum test and update snaps

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    db6718e View commit details
    Browse the repository at this point in the history

  21. Merge branch 'main' into eladb/add-phase-to-typecheck

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    5055f82 View commit details
    Browse the repository at this point in the history

  22. fix parser

    @eladb
    eladb committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    7d9a7d2 View commit details
    Browse the repository at this point in the history

  23. chore: self mutation 

    Signed-off-by: monada-bot[bot] <[email protected]>
    @monadabot
    monadabot committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    5b91ea5 View commit details
    Browse the repository at this point in the history