chore(compiler): type references as expressions and phase tracking #3177

eladb · 2023-06-30T05:59:31Z

No functional changes, preparatory pull request as part of the expression lifting escapade.

Type references are expressions that reference type names. It's valuable to model them as expressions because they are needed at runtime. Once they are modeled as expressions, we can treat all expressions equally when it comes to lifting (which is the motivation for this refactor).

We've changed the following places to use type references instead of a UserDefinedType. In all of these cases the types have a runtime presence. The rest of the places are just type annotations that are erased at runtime:

The class being instantiated in new expressions
Base classes
The type component in a Reference::TypeMember (static access).

Furthermore, to support expression lifting, the type checker now records the phase of each expression during type checking and makes it available through get_expr_phase.

Additionally, changed the left-hand-side of an assignment statement to be an Expr and not a Reference. Also in order to be able to lift it.

Turn the variable component of StmtKind::Assignment from a simple Symbol to an Expr in order for it to also hold type and phase information.

The JSII importer accidentally imported structs as preflight while they should be phase-independent.

Misc: strip excess newlines when adding a line to CodeMaker.

Checklist

Title matches Winglang's style guide
Description explains motivation and solution
Tests added (always)
Docs updated (only required for features)
Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.

No functional changes, preparatory pull request as part of the expression lifting escapade. To support expression lifting, the type checker now records the phase of each expression during type checking and makes it available through `get_expr_phase`. Additionally, turn the variable component of `StmtKind::Assignment` from a simple `Symbol` to an `Expr` in order for it to also hold type and phase information. The JSII importer accidentally imported structs as `preflight` while they should be phase-independent. Misc: strip excess newlines when adding a line to `CodeMaker`.

Signed-off-by: monada-bot[bot] <[email protected]>

staycoolcall911

Thanks to the detailed PR description reviewing was a breeze...

libs/wingc/src/type_check.rs

tools/hangar/__snapshots__/invalid.ts.snap

Fixes #2916 by returning exit code 0 when tests fail. ## Misc Tweaks to a bunch of tests. ## Checklist - [x] Title matches [Winglang's style guide](https://docs.winglang.io/contributing/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [x] Docs updated (only required for features) - [x] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://docs.winglang.io/terms-and-policies/contribution-license.html)*.

…pecheck

tools/hangar/__snapshots__/invalid.ts.snap

eladb · 2023-06-30T14:21:45Z

@MarkMcCulloh I'll make sure all the diagnostics around base classes are fixed. If that's all, I'd appreciate an approval so I can be unblocked with my next step.

Signed-off-by: monada-bot[bot] <[email protected]>

MarkMcCulloh

I'll make sure all the diagnostics around base classes are fixed. If that's all, I'd appreciate an approval so I can be unblocked with my next step.

Yeah LGTM as long as the diags are fixed. Luckily the grammar still prevents real expressions into places where types are expected so we might be safe from some new big regressions.

I also think @yoav-steinberg should take a look at this, but I'll leave that to you if you want to wait.

Signed-off-by: monada-bot[bot] <[email protected]>

eladb · 2023-06-30T15:15:13Z

Thanks. I'll check with @yoav-steinberg if he is available

libs/wingc/src/ast.rs

libs/wingc/src/type_check.rs

examples/tests/invalid/inflight_reassign.w

Co-authored-by: Chris Rybicki <[email protected]>

mergify · 2023-06-30T19:00:44Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Signed-off-by: monada-bot[bot] <[email protected]>

mergify · 2023-06-30T20:18:52Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

monadabot · 2023-06-30T20:56:40Z

Congrats! 🚀 This was released in Wing 0.23.5.

…3177) No functional changes, preparatory pull request as part of the expression lifting escapade. Type references are expressions that reference type names. It's valuable to model them as expressions because they are needed at runtime. Once they are modeled as expressions, we can treat all expressions equally when it comes to lifting (which is the motivation for this refactor). We've changed the following places to use type references instead of a `UserDefinedType`. In all of these cases the types have a runtime presence. The rest of the places are just type annotations that are erased at runtime: - The class being instantiated in `new` expressions - Base classes - The type component in a `Reference::TypeMember` (static access). Furthermore, to support expression lifting, the type checker now records the phase of each expression during type checking and makes it available through `get_expr_phase`. Additionally, changed the left-hand-side of an assignment statement to be an `Expr` and not a `Reference`. Also in order to be able to lift it. Turn the variable component of `StmtKind::Assignment` from a simple `Symbol` to an `Expr` in order for it to also hold type and phase information. The JSII importer accidentally imported structs as `preflight` while they should be phase-independent. Misc: strip excess newlines when adding a line to `CodeMaker`. ## Checklist - [x] Title matches [Winglang's style guide](https://docs.winglang.io/contributing/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [x] Docs updated (only required for features) - [x] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Monada Contribution License](https://docs.winglang.io/terms-and-policies/contribution-license.html)*.

staycoolcall911 · 2023-06-30T13:20:39Z

examples/tests/invalid/enums.w

@@ -2,8 +2,8 @@ enum SomeEnum {
    ONE, TWO, THREE
 }

-let four = SomeEnum.FOUR;
-// ERR              ^^^^ enum value does not exist
+// let four = SomeEnum.FOUR;


Is that commented out on purpose?

eladb requested a review from a team as a code owner June 30, 2023 05:59

eladb and others added 2 commits June 30, 2023 09:06

left overs

e9f2b5d

chore: self mutation

59b72d3

Signed-off-by: monada-bot[bot] <[email protected]>

eladb changed the title ~~chore: add phase to each expression during type checking~~ chore(compiler): treat type references as expressions and track phases Jun 30, 2023

staycoolcall911 approved these changes Jun 30, 2023

View reviewed changes

libs/wingc/src/type_check.rs Show resolved Hide resolved

tools/hangar/__snapshots__/invalid.ts.snap Show resolved Hide resolved

eladb added 4 commits June 30, 2023 16:09

Type references

460f633

merge

7394012

Merge remote-tracking branch 'origin/main' into eladb/add-phase-to-ty…

a289ac2

…pecheck

eladb requested a review from staycoolcall911 June 30, 2023 13:15

remove stale files from previous lift

84933db

MarkMcCulloh reviewed Jun 30, 2023

View reviewed changes

fix invalid logic

fa903ff