fix(lidar_centerpoint, pointpainting): increase CAPACITY_POINT to avoid crashing #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id crashing Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
requested review from
knzo25,
kminoda,
badai-nguyen,
ktro2828,
miursh,
tzhong518,
YoshiRi and
yukkysaito
as code owners
TomohitoAndo
changed the title
|
TomohitoAndo
requested review from
saka1-s and
kotaro-hihara
and removed request for
knzo25,
yukkysaito,
YoshiRi,
miursh,
kminoda,
tzhong518,
ktro2828 and
badai-nguyen
TomohitoAndo
added a commit
that referenced
this pull request
Oct 1, 2024
…id crashing (#1546) Signed-off-by: Tomohito Ando <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR increases CAPACITY_POINT to avoid crashing due to the large number of points.
Since the following PR also addresses this issue, I tried to cherry-pick it, but there were too many conflicts.
Therefore, I directly changed the CAPACITY_POINT in the current code.
Related links
TIER IV INTERNAL
How was this PR tested?
I confirmed node doesn't crash on the bench environment.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.