Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gnss_launch): added autoware prefix to gnss_poser #277

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Aug 2, 2024

Description

Following the movement of adding autoware_ prefix to package names in autoware.universe, this PR adds autoware prefix to gnss_poser.

How was this PR tested?

Confirmed that gnss_poser launches and works as normal with the AWF/autoware.universe (with PR 8323).
(Only tested by aip_x2)

Related links

Since this PR strongly relates to sensor launching systems, this PR must be merged together with the following PRs.

@TaikiYamada4
Copy link
Contributor Author

@tkimura4 @shmpwk
Sorry for interrupting. 🙏
I chose you as reviewers since I'm not sure who's in charge in this area.
If there is someone much suitable could please set that person as the reviewer of this PR?

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit d182115 into tier4/universe Aug 2, 2024
14 of 18 checks passed
@tkimura4 tkimura4 deleted the chore/gnss_poser/add_autoware_prefix branch August 2, 2024 14:04
kyoichi-sugahara added a commit that referenced this pull request Aug 3, 2024
kyoichi-sugahara added a commit that referenced this pull request Aug 3, 2024
…#277) (#278)

Revert "chore(gnss_launch): added autoware prefix to gnss_poser (#277)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants