Populate type for HGNC & Alliance gene nodes #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe field for human genes. Also enables the type field for Alliance genes, which was commented out previously. Plus tests.
AO33
approved these changes
Sep 6, 2024
amc-corey-cox
requested changes
Sep 9, 2024
There was a problem hiding this comment.
It looks like there is a small error in the bash script update with gzcat and zcat. I think it needs to de-reference the variable when you call zcat. Also, the style begs for changing the name of the cat variable to be more clear we're using a variable reference to a tool rather than a tool name.
|
This could go in... but I think there may be an error in after_download.sh. Please correct me if I've misunderstood how that will work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a lookup table for HGNC to SO term ID to populate the biolink type field for human genes. Also enables the type field for Alliance genes, which was commented out previously. Plus tests.**
Additionally, there are some unrelated formatting changes that came in as well.
Fixes #649
Update to add: The alternate approach would be to create a mapping table from the type strings provided by HGNC directly which in retrospect does sound like it's a little more maintainable. I'm open to rolling this back and going that way instead.