Fixes for PowerToys Awake

[dend]

Addresses the following issues:

• Bug in right-click menu of Awake app icon in the notification area  #12145
• Fix timed keep awake CPU spin cycle #12052
• Awake seeming to spam notification tray #11940

[Aaron-Junker]

@dend Why don't you just follow our Pull Request template? I just want to know what holds you back? Is there anything I'm overlooking here?

[dend]

@dend Why don't you just follow our Pull Request template? I just want to know what holds you back? Is there anything I'm overlooking here?

Nothing big @Aaron-Junker - I just wanted to use a very simplified version of it. Since I am just fixing my own tool, and y'all know who I am - thought I would just keep it brief.

[dend]

This should be ready for review.

Before merging: I'd love a sanity check from folks to clone this PR, build and run PowerToys, and see if Awake works on your machine. I've made a few changes that address the reported bugs, but I want to make sure that it actually works on more than my machine.

[dend]

Actually, after restarting PowerToys, there's no Awake icon in the system tray.
I've exited PowerToys and then started it again and there's no tray icon for Awake.

@jaimecbernardo is the module enabled in PowerToys settings? Can you check and see if the process is running in Task Manager (PowerToys.Awake.exe)?

[mykhailopylyp]

@dend
I can also confirm that I don't have the icon in the tray.
PowerToys.Awake.exe process is running. Awake is enabled in the settings and there is an exception in event logs

Application: PowerToys.Awake.exe
CoreCLR Version: 4.700.21.21202
.NET Core Version: 3.1.15
Description: The process was terminated due to an unhandled exception.
Exception Info: System.NullReferenceException: Object reference not set to an instance of an object.
   at Awake.Program.ForceExit(String message, Int32 exitCode)
   at Awake.Program.Main(String[] args)

[mykhailopylyp]

@dend
This pr should've been divided into a few smaller ones. In this way, we can get them in faster. The rule of thumb is "one issue one pr".

[dend]

@mykhailopylyp - I will double-check once again to see what is going on with the icon, and where I am failing with ForceExit. Expect that change to be available today.

[dend]

@dend
I can also confirm that I don't have the icon in the tray.
PowerToys.Awake.exe process is running. Awake is enabled in the settings and there is an exception in event logs

Application: PowerToys.Awake.exe
CoreCLR Version: 4.700.21.21202
.NET Core Version: 3.1.15
Description: The process was terminated due to an unhandled exception.
Exception Info: System.NullReferenceException: Object reference not set to an instance of an object.
   at Awake.Program.ForceExit(String message, Int32 exitCode)
   at Awake.Program.Main(String[] args)

@mykhailopylyp can you please confirm that you are using the content from this PR? ForceExit has been renamed to Exit with a bunch of changes here, so it's odd to see that in logs.

New changes made in code.

[mykhailopylyp]

@mykhailopylyp can you please confirm that you are using the content from this PR? ForceExit has been renamed to Exit with a bunch of changes here, so it's odd to see that in logs.

Sorry for the confusion. This crash wasn't caused by this branch.

[mykhailopylyp]

LGTM, tested, works as expected. Thank you for your contribution!

[dend]

Awesome - thanks for checking @mykhailopylyp 👏

@crutkas anything else we need here before we can merge?

[dend]

@dedavis6797 FYI - let me know if I need to make any other changes for us to merge this PR.

[mykhailopylyp]

Let's wait for @jaimecbernardo's review as he found some issues

[jaimecbernardo]

I'll do a review today still. And if it's all OK, I'll merge it.

[jaimecbernardo]

After keeping the computer awake temporarily, the computer can go to sleep after the time we set, but the setting never changes in the UI. The visuals show as if the mode is still "Keep awake temporarily" instead of resetting to "Off (Passive)".

This is still occurring to me. After being kept awake temporarily, the behavior returns as if it is "Off (Passive)" but the UI still shows as if the setting is to be kept awake temporarily.

[dend]

@jaimecbernardo this is by-design - the UI in the Settings view doesn't automatically update today. This will be an area I will look at improving in a separate release.

By design in the current release

[jaimecbernardo]

The changes LGTM.
Great work!