[v0.20] Merge pull request #2154 from rmweir/only-uninstall-reset #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior, the reset flag indicated that resources should be uninstalled. However, if an existing deployment was not detected, all other resources were removed regardless of the reset flag's value. Now, reset must be set to true to uninstall any existing vCluster Platform resources. This is more in line with how a reinstall performed with helm behaves and is more predictable for the user. The usage description has been updated to reflect the change. (cherry picked from commit 870f1c7)
FabianKramm
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov0.20:Questions ?
Please refer to the Backport tool documentation