Only uninstall if reset flag is true #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
Prior, the reset flag indicated that resources should be uninstalled. However, if an existing deployment was not detected, all other resources were removed regardless of the reset flag's value. Now, reset must be set to true to uninstall any existing vCluster Platform resources. This is more in line with how a reinstall performed with helm behaves and is more predictable for the user. The usage description has been updated to reflect the change.
rmweir
force-pushed
the
only-uninstall-reset
branch
from
34e0e2f
to
870f1c7
Compare
FabianKramm
approved these changes
Sep 19, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Sep 19, 2024
[v0.20] Merge pull request #2154 from rmweir/only-uninstall-reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Fixes ENG-4635.
Part of ENG-4400
Prior, the reset flag indicated that resources should be uninstalled. However, if an existing deployment was not detected, all other resources were removed regardless of the reset flag's value. Now, reset must be set to true to uninstall any existing vCluster Platform resources. This is more in line with how a reinstall performed with helm behaves and is more predictable for the user. The usage description has been updated to reflect the change.
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vCluster uninstall would remove vCluster Platform resources from a previous install even if the "--reset" flag was set to false.
What else do we need to know?