Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.20] Merge pull request #2154 from rmweir/only-uninstall-reset #2157

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[v0.20] Merge pull request #2154 from rmweir/only-uninstall-reset #2157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/vclusterctl/cmd/platform/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ before running this command:
startCmd.Flags().BoolVar(&cmd.ReuseValues, "reuse-values", true, "Reuse previous vCluster platform helm values on upgrade")
startCmd.Flags().BoolVar(&cmd.Upgrade, "upgrade", false, "If true, vCluster platform will try to upgrade the release")
startCmd.Flags().StringVar(&cmd.Email, "email", "", "The email to use for the installation")
startCmd.Flags().BoolVar(&cmd.Reset, "reset", false, "If true, an existing vCluster platform instance will be deleted before installing vCluster platform")
startCmd.Flags().BoolVar(&cmd.Reset, "reset", false, "If true, existing vCluster Platform resources, including the deployment, will be deleted before installing vCluster platform")
startCmd.Flags().BoolVar(&cmd.NoWait, "no-wait", false, "If true, vCluster platform will not wait after installing it")
startCmd.Flags().BoolVar(&cmd.NoPortForwarding, "no-port-forwarding", false, "If true, vCluster platform will not do port forwarding after installing it")
startCmd.Flags().BoolVar(&cmd.NoTunnel, "no-tunnel", false, "If true, vCluster platform will not create a loft.host tunnel for this installation")
Expand Down
11 changes: 0 additions & 11 deletions pkg/cli/start/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,6 @@ func (l *LoftStarter) Start(ctx context.Context) error {
l.Log.Info(product.Replace("Welcome to Loft!"))
l.Log.Info(product.Replace("This installer will help you configure and deploy Loft."))

// make sure we are ready for installing
err = l.prepareInstall(ctx)
if err != nil {
return err
}

err = l.upgradeLoft()
if err != nil {
return err
Expand All @@ -127,11 +121,6 @@ func (l *LoftStarter) Start(ctx context.Context) error {
return l.success(ctx)
}

func (l *LoftStarter) prepareInstall(ctx context.Context) error {
// delete admin user & secret
return clihelper.UninstallLoft(ctx, l.KubeClient, l.RestConfig, l.Context, l.Namespace, log.Discard)
}

func (l *LoftStarter) prepare() error {
platformClient := platform.NewClientFromConfig(l.LoadedConfig(l.Log))

Expand Down
Loading