Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-4603: Update crashloopbackoff for 1.32 #21

Closed
wants to merge 70 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
5d58111
Add KEP files for Tune CrashLoopBackoff
lauralorenz Apr 30, 2024
d673b10
Motivation, alternatives and summary updates
lauralorenz Jun 3, 2024
7ad0733
Update proposal section with basics
lauralorenz Jun 3, 2024
dfa3301
Fill in rest of proposal section
lauralorenz Jun 4, 2024
e8017ad
Add graduation criteria
lauralorenz Jun 4, 2024
d1bcfc9
Fix images and some prose
lauralorenz Jun 4, 2024
830b013
Clarify lingo for restartable init containers aka sidecars
lauralorenz Jun 4, 2024
eebd38b
Simplify general backoff curve update and move catch up mechanic to A…
lauralorenz Jun 4, 2024
636d1dc
Match summary with last change
lauralorenz Jun 4, 2024
aa32291
Move an API alternative out of inline
lauralorenz Jun 6, 2024
64fe4cd
Move Success to alternatives, major updates to design details
lauralorenz Jun 6, 2024
7de94ab
Explain success vs rapid in alternatives
lauralorenz Jun 6, 2024
fbc6896
PRR questionnaire
lauralorenz Jun 6, 2024
4543df0
Merge branch 'kubernetes:master' into kep-4603-tune-crashloopbackoff-…
lauralorenz Jun 6, 2024
225a4ea
Update TOC
lauralorenz Jun 6, 2024
a443965
Add prr file and udpate kep.yaml
lauralorenz Jun 6, 2024
385894f
Move some things around so proposal is easier to read
lauralorenz Jun 6, 2024
6398de4
Add details for On Success notes
lauralorenz Jun 11, 2024
08a81f2
Add approver
lauralorenz Jun 11, 2024
3001a42
Fix some rewrap and an unfinished sentence
lauralorenz Jun 11, 2024
e513863
Add rationale and clarity on late recovery and what this KEP doesn't …
lauralorenz Jun 11, 2024
6e9517a
Adding implementation history milestones for KEP
lauralorenz Jun 11, 2024
adf8d04
Add upgrade/downgrade strategy section
lauralorenz Jun 11, 2024
b1feb73
Add metrics discussion re: rollback
lauralorenz Jun 12, 2024
64a1207
Fix toc, verify and go test errors
lauralorenz Jun 12, 2024
0deaea2
Fix some headers, add Drawbacks section
lauralorenz Jun 12, 2024
875d4b4
Add Risks & Mitigations section
lauralorenz Jun 12, 2024
764e174
Update test plan section
lauralorenz Jun 12, 2024
9d3daed
Version Skew update
lauralorenz Jun 12, 2024
8caa42a
Observability --> Benchmarking, and clean up alternatives
lauralorenz Jun 12, 2024
034c0fd
Fix formatting
lauralorenz Jun 12, 2024
3d4f378
I think we're implementable people
lauralorenz Jun 12, 2024
368fc9d
Wrong number for PRR artifact
lauralorenz Jun 12, 2024
b018a68
spelling miss
lauralorenz Jun 13, 2024
9f70587
reformat feature gate definitions
lauralorenz Jun 13, 2024
a5573b5
Merge branch 'kubernetes:master' into kep-4603-tune-crashloopbackoff-…
lauralorenz Sep 9, 2024
299d699
Add note about movements in Job API backoffLimit behavior
lauralorenz Sep 9, 2024
a0187a9
Big reorg to make way for a 1.32 proposal
lauralorenz Sep 9, 2024
12a2dac
back to provisional
lauralorenz Sep 9, 2024
01b431e
Update TOC
lauralorenz Sep 9, 2024
767def9
Transfer questions from PR to add to analysis section
lauralorenz Sep 9, 2024
ee72b80
Transfer other comments
lauralorenz Sep 9, 2024
5dfcba1
Clarify the success situation
lauralorenz Sep 9, 2024
005428d
Add why not for the Rapid case
lauralorenz Sep 9, 2024
121252c
Remove PRR review artifact from this PR
lauralorenz Sep 9, 2024
63c39cd
More formally add unresolved tags around entire proposal sections
lauralorenz Sep 16, 2024
3763100
Clarify on alpha feature gates
lauralorenz Sep 16, 2024
00d1011
Update proposal and risk section for 1.32
lauralorenz Sep 17, 2024
1273fbd
Add refactor for backoff counter reset threshold, and resolve major d…
lauralorenz Sep 20, 2024
978d99d
Cleanup TODO and lingering unresolved tag
lauralorenz Sep 20, 2024
1461b6a
Reformatting some paragraphs
lauralorenz Sep 23, 2024
03c1284
Update kubelet overhead analysis
lauralorenz Sep 23, 2024
83ca22b
rewrap
lauralorenz Sep 23, 2024
fb56335
Update more per node details
lauralorenz Sep 24, 2024
e0f35ba
Specify kubelet configuration implementation
lauralorenz Sep 24, 2024
a4412ed
Update graduation criteria with 1.32 proposal stuff
lauralorenz Sep 24, 2024
21caaa6
Update with conflict resolution info
lauralorenz Sep 24, 2024
c9f7bad
Internal consistency and proofreading run
lauralorenz Sep 24, 2024
c3d9e2c
Add some new unresolved tags from IRL comments
lauralorenz Sep 24, 2024
b879c7f
Clean up some unresolved's to undraft
lauralorenz Sep 30, 2024
0293f6f
Update graphs, remove some other unresolveds
lauralorenz Sep 30, 2024
9229a7d
Add new graphs
lauralorenz Sep 30, 2024
a31f622
Add conflict resolution table
lauralorenz Sep 30, 2024
5a50201
Fix napkin math in risks and mitigations
lauralorenz Sep 30, 2024
154a5c9
Address free restart issue in design details
lauralorenz Sep 30, 2024
ea3988f
Fix some lingering unresolveds
lauralorenz Sep 30, 2024
97cb477
Remove benchmarking ifftt, can add later
lauralorenz Sep 30, 2024
d81363d
Update toc
lauralorenz Sep 30, 2024
40073eb
spelling
lauralorenz Sep 30, 2024
5997b34
update some grad criteria and version skew info
lauralorenz Oct 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,776 changes: 1,776 additions & 0 deletions keps/sig-node/4603-tune-crashloopbackoff/README.md

Large diffs are not rendered by default.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
52 changes: 52 additions & 0 deletions keps/sig-node/4603-tune-crashloopbackoff/kep.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
title: Tune Crashloop Backoff
kep-number: 4603
authors:
- "@lauralorenz"
owning-sig: sig-node
# participating-sigs:
# - sig-aaa
# - sig-bbb
status: provisional
creation-date: 2024-04-29
reviewers:
- "@tallclair"
- "@pehunt"
approvers:
- "SergeyKanzhelev"

# see-also:
# - "/keps/sig-aaa/1234-we-heard-you-like-keps"
# - "/keps/sig-bbb/2345-everyone-gets-a-kep"
# replaces:
# - "/keps/sig-ccc/3456-replaced-kep"

# The target maturity stage in the current dev cycle for this KEP.
stage: alpha

# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.32"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.32"
# beta: "v1.34"
# stable: "v1.37"

# The following PRR answers are required at alpha release
# List the feature gate name and the components for which it must be enabled
feature-gates:
- name: ReduceDefaultCrashLoopBackoffDecay
components:
- kube-apiserver
- kubelet
# - name: EnableRapidCrashLoopBackoffDecay
# components:
# - kube-apiserver
# - kubelet
disable-supported: true

# The following PRR answers are required at beta release
# metrics:
# - my_feature_metric
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.