Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4603: Update crashloopbackoff for 1.32 #21

Closed
wants to merge 70 commits into from
Closed

KEP-4603: Update crashloopbackoff for 1.32 #21

wants to merge 70 commits into from

Conversation

lauralorenz
Copy link
Owner

@lauralorenz lauralorenz commented Sep 17, 2024 •
edited
Loading

  • One-line PR description: Tunable CrashLoopBackoff proposal for 1.32 based on new defaults and node level (via kubelet flag) max backoff configuration
  • Other comments:

@lauralorenz
Add KEP files for Tune CrashLoopBackoff
5d58111 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Motivation, alternatives and summary updates
d673b10 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update proposal section with basics
7ad0733 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Fill in rest of proposal section
dfa3301 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add graduation criteria
e8017ad 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Fix images and some prose
d1bcfc9 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Clarify lingo for restartable init containers aka sidecars
830b013 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Simplify general backoff curve update and move catch up mechanic to A…
eebd38b 
…lternatives

Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Match summary with last change
636d1dc 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Move an API alternative out of inline
aa32291 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Move Success to alternatives, major updates to design details
64fe4cd 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Explain success vs rapid in alternatives
7de94ab 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
PRR questionnaire
fbc6896 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Merge branch 'kubernetes:master' into kep-4603-tune-crashloopbackoff-…
4543df0 
…node
@lauralorenz
Update TOC
225a4ea 
Signed-off-by: lauralorenz <[email protected]>
@lauralorenz
Add prr file and udpate kep.yaml
a443965 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Move some things around so proposal is easier to read
385894f 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add details for On Success notes
6398de4 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add approver
08a81f2 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Fix some rewrap and an unfinished sentence
3001a42 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add rationale and clarity on late recovery and what this KEP doesn't …
e513863 
…touch

Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Adding implementation history milestones for KEP
6e9517a 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add upgrade/downgrade strategy section
adf8d04 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add metrics discussion re: rollback
b1feb73 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Fix toc, verify and go test errors
64a1207 
Signed-off-by: lauralorenz <[email protected]>
@lauralorenz
Fix some headers, add Drawbacks section
0deaea2 
Signed-off-by: lauralorenz <[email protected]>
@lauralorenz
Add Risks & Mitigations section
875d4b4 
Signed-off-by: lauralorenz <[email protected]>
@lauralorenz
Update test plan section
764e174 
Signed-off-by: lauralorenz <[email protected]>
@lauralorenz
Version Skew update
9d3daed 
Signed-off-by: lauralorenz <[email protected]>
@lauralorenz
Observability --> Benchmarking, and clean up alternatives
8caa42a 
Signed-off-by: lauralorenz <[email protected]>
@lauralorenz lauralorenz mentioned this pull request Sep 17, 2024
Open
4 tasks
@lauralorenz lauralorenz changed the title Update crashloopbackoff for 1.32 KEP-4603: Update crashloopbackoff for 1.32 Sep 17, 2024
@lauralorenz lauralorenz mentioned this pull request Sep 20, 2024
Merged
@lauralorenz
Cleanup TODO and lingering unresolved tag
978d99d 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Reformatting some paragraphs
1461b6a 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update kubelet overhead analysis
03c1284 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
rewrap
83ca22b 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update more per node details
fb56335 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Specify kubelet configuration implementation
e0f35ba 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update graduation criteria with 1.32 proposal stuff
a4412ed 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update with conflict resolution info
21caaa6 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Internal consistency and proofreading run
c9f7bad 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add some new unresolved tags from IRL comments
c3d9e2c 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Clean up some unresolved's to undraft
b879c7f 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz lauralorenz marked this pull request as ready for review September 30, 2024 17:10
@lauralorenz
Update graphs, remove some other unresolveds
0293f6f 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add new graphs
9229a7d 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Add conflict resolution table
a31f622 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Fix napkin math in risks and mitigations
5a50201 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Address free restart issue in design details
154a5c9 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Fix some lingering unresolveds
ea3988f 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Remove benchmarking ifftt, can add later
97cb477 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
Update toc
d81363d 
Signed-off-by: lauralorenz <[email protected]>
@lauralorenz
spelling
40073eb 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz
update some grad criteria and version skew info
5997b34 
Signed-off-by: Laura Lorenz <[email protected]>
@lauralorenz lauralorenz changed the base branch from kep-4603-tune-crashloopbackoff-node to master October 2, 2024 04:36
@lauralorenz
Copy link
Owner Author

Closing in favor of PR to upstream (couldn't change the base of this PR to a different remote): kubernetes#4893

@lauralorenz lauralorenz closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lauralorenz