Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4603: Update crashloopbackoff for 1.32 #21

Closed
wants to merge 70 commits into from
Closed

KEP-4603: Update crashloopbackoff for 1.32 #21

wants to merge 70 commits into from

Commits on Apr 30, 2024

  1. Add KEP files for Tune CrashLoopBackoff 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    5d58111 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Motivation, alternatives and summary updates 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d673b10 View commit details
    Browse the repository at this point in the history

  2. Update proposal section with basics 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7ad0733 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Fill in rest of proposal section 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    dfa3301 View commit details
    Browse the repository at this point in the history

  2. Add graduation criteria 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    e8017ad View commit details
    Browse the repository at this point in the history

  3. Fix images and some prose 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d1bcfc9 View commit details
    Browse the repository at this point in the history

  4. Clarify lingo for restartable init containers aka sidecars 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    830b013 View commit details
    Browse the repository at this point in the history

  5. Simplify general backoff curve update and move catch up mechanic to A… 

    …lternatives

Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    eebd38b View commit details
    Browse the repository at this point in the history

  6. Match summary with last change 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    636d1dc View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Move an API alternative out of inline 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    aa32291 View commit details
    Browse the repository at this point in the history

  2. Move Success to alternatives, major updates to design details 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    64fe4cd View commit details
    Browse the repository at this point in the history

  3. Explain success vs rapid in alternatives 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7de94ab View commit details
    Browse the repository at this point in the history

  4. PRR questionnaire 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fbc6896 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'kubernetes:master' into kep-4603-tune-crashloopbackoff-… 

    …node
    @lauralorenz
    lauralorenz authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4543df0 View commit details
    Browse the repository at this point in the history

  6. Update TOC 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    225a4ea View commit details
    Browse the repository at this point in the history

  7. Add prr file and udpate kep.yaml 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a443965 View commit details
    Browse the repository at this point in the history

  8. Move some things around so proposal is easier to read 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    385894f View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Add details for On Success notes 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6398de4 View commit details
    Browse the repository at this point in the history

  2. Add approver 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    08a81f2 View commit details
    Browse the repository at this point in the history

  3. Fix some rewrap and an unfinished sentence 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3001a42 View commit details
    Browse the repository at this point in the history

  4. Add rationale and clarity on late recovery and what this KEP doesn't … 

    …touch

Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e513863 View commit details
    Browse the repository at this point in the history

  5. Adding implementation history milestones for KEP 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6e9517a View commit details
    Browse the repository at this point in the history

  6. Add upgrade/downgrade strategy section 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    adf8d04 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Add metrics discussion re: rollback 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    b1feb73 View commit details
    Browse the repository at this point in the history

  2. Fix toc, verify and go test errors 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    64a1207 View commit details
    Browse the repository at this point in the history

  3. Fix some headers, add Drawbacks section 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    0deaea2 View commit details
    Browse the repository at this point in the history

  4. Add Risks & Mitigations section 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    875d4b4 View commit details
    Browse the repository at this point in the history

  5. Update test plan section 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    764e174 View commit details
    Browse the repository at this point in the history

  6. Version Skew update 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9d3daed View commit details
    Browse the repository at this point in the history

  7. Observability --> Benchmarking, and clean up alternatives 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    8caa42a View commit details
    Browse the repository at this point in the history

  8. Fix formatting 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    034c0fd View commit details
    Browse the repository at this point in the history

  9. I think we're implementable people 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    3d4f378 View commit details
    Browse the repository at this point in the history

  10. Wrong number for PRR artifact 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    368fc9d View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. spelling miss 

    Co-authored-by: Maciej Szulik <[email protected]>
    @lauralorenz @soltysh
    lauralorenz and soltysh authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    b018a68 View commit details
    Browse the repository at this point in the history

  2. reformat feature gate definitions 

    Co-authored-by: Tim Allclair <[email protected]>
    @lauralorenz @tallclair
    lauralorenz and tallclair authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    9f70587 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge branch 'kubernetes:master' into kep-4603-tune-crashloopbackoff-… 

    …node
    @lauralorenz
    lauralorenz authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a5573b5 View commit details
    Browse the repository at this point in the history

  2. Add note about movements in Job API backoffLimit behavior 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    299d699 View commit details
    Browse the repository at this point in the history

  3. Big reorg to make way for a 1.32 proposal 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a0187a9 View commit details
    Browse the repository at this point in the history

  4. back to provisional 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    12a2dac View commit details
    Browse the repository at this point in the history

  5. Update TOC 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    01b431e View commit details
    Browse the repository at this point in the history

  6. Transfer questions from PR to add to analysis section 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    767def9 View commit details
    Browse the repository at this point in the history

  7. Transfer other comments 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ee72b80 View commit details
    Browse the repository at this point in the history

  8. Clarify the success situation 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5dfcba1 View commit details
    Browse the repository at this point in the history

  9. Add why not for the Rapid case 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    005428d View commit details
    Browse the repository at this point in the history

  10. Remove PRR review artifact from this PR 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    121252c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. More formally add unresolved tags around entire proposal sections 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    63c39cd View commit details
    Browse the repository at this point in the history

  2. Clarify on alpha feature gates 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3763100 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Update proposal and risk section for 1.32 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    00d1011 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Add refactor for backoff counter reset threshold, and resolve major d… 

    …esign details

Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1273fbd View commit details
    Browse the repository at this point in the history

  2. Cleanup TODO and lingering unresolved tag 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    978d99d View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Reformatting some paragraphs 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1461b6a View commit details
    Browse the repository at this point in the history

  2. Update kubelet overhead analysis 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    03c1284 View commit details
    Browse the repository at this point in the history

  3. rewrap 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    83ca22b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Update more per node details 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fb56335 View commit details
    Browse the repository at this point in the history

  2. Specify kubelet configuration implementation 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e0f35ba View commit details
    Browse the repository at this point in the history

  3. Update graduation criteria with 1.32 proposal stuff 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a4412ed View commit details
    Browse the repository at this point in the history

  4. Update with conflict resolution info 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    21caaa6 View commit details
    Browse the repository at this point in the history

  5. Internal consistency and proofreading run 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c9f7bad View commit details
    Browse the repository at this point in the history

  6. Add some new unresolved tags from IRL comments 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c3d9e2c View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Clean up some unresolved's to undraft 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b879c7f View commit details
    Browse the repository at this point in the history

  2. Update graphs, remove some other unresolveds 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0293f6f View commit details
    Browse the repository at this point in the history

  3. Add new graphs 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9229a7d View commit details
    Browse the repository at this point in the history

  4. Add conflict resolution table 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a31f622 View commit details
    Browse the repository at this point in the history

  5. Fix napkin math in risks and mitigations 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    5a50201 View commit details
    Browse the repository at this point in the history

  6. Address free restart issue in design details 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    154a5c9 View commit details
    Browse the repository at this point in the history

  7. Fix some lingering unresolveds 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ea3988f View commit details
    Browse the repository at this point in the history

  8. Remove benchmarking ifftt, can add later 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    97cb477 View commit details
    Browse the repository at this point in the history

  9. Update toc 

    Signed-off-by: lauralorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d81363d View commit details
    Browse the repository at this point in the history

  10. spelling 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    40073eb View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. update some grad criteria and version skew info 

    Signed-off-by: Laura Lorenz <[email protected]>
    @lauralorenz
    lauralorenz committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5997b34 View commit details
    Browse the repository at this point in the history