-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory usage in component fetches and change detection filters #15283
Open
ItsDoot
wants to merge
1
commit into
bevyengine:main
Choose a base branch
from
ItsDoot:fetchmemoryusage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+311
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: james7132 <[email protected]>
ItsDoot
added
A-ECS
Entities, components, systems, and events
C-Performance
A change motivated by improving speed, memory usage or compile times
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
D-Unsafe
Touches with unsafe code in some way
labels
Sep 18, 2024
Full ECS benchmark suite results (this PR on left)
|
Code changes seem reasonable, but those benchmark results are super weird. Why would only some of the busy_systems benchmarks have a 40%+ slowdown? Can you rerun them and post the results? |
@alice-i-cecile Reran on a different machine: Full ECS suite benchmarks (this PR on left)
|
Okay, thanks :) I'm happy to call the benchmarks largely noise. Reducing memory usage has its own value though, so I'm in favor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ECS
Entities, components, systems, and events
C-Performance
A change motivated by improving speed, memory usage or compile times
D-Unsafe
Touches with unsafe code in some way
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Same as #6396, we use a compile-time checked
StorageSwitch
union type to select the fetch data based on the component's storage type, saving >= 8 bytes per component fetch in a given query.Note: We forego the Query iteration change as it exists in a slightly different form now on main.
Testing