fix(autoware_utils): address self-intersecting polygons in random_concave_generator and handle empty inners() during triangulation #8995
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.02 (5.12 -> 5.10)
- Improving Code Health: 2 findings(s) ✅
Details
✅ Improving Code Health:
- Overall Code Complexity ear_clipping.cpp
- Overall Code Complexity random_concave_polygon.cpp
Annotations
Check notice on line 1 in common/autoware_universe_utils/src/geometry/ear_clipping.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.59 to 5.34, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 1 in common/autoware_universe_utils/src/geometry/random_concave_polygon.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.73 to 4.67, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 1 in common/autoware_universe_utils/src/geometry/alt_geometry.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.50 to 4.57, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 1 in common/autoware_universe_utils/test/src/geometry/test_geometry.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Lines of Code in a Single File
The lines of code increases from 1898 to 1968, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 2112 in common/autoware_universe_utils/test/src/geometry/test_geometry.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Large Method
TEST:geometry:PolygonTriangulation has 70 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.