Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_utils): address self-intersecting polygons in random_concave_generator and handle empty inners() during triangulation #8995

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

move area calculation to test

e141914
Select commit
Loading
Failed to load commit list.
Open

fix(autoware_utils): address self-intersecting polygons in random_concave_generator and handle empty inners() during triangulation #8995

move area calculation to test
e141914
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Oct 3, 2024 in 38s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.03 (5.12 -> 5.09)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Overall Code Complexity random_concave_polygon.cpp

Annotations

Check notice on line 1 in common/autoware_universe_utils/src/geometry/ear_clipping.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 5.59 to 5.63, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 1 in common/autoware_universe_utils/src/geometry/random_concave_polygon.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 4.73 to 4.67, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 1 in common/autoware_universe_utils/src/geometry/alt_geometry.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 4.50 to 4.57, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 1 in common/autoware_universe_utils/test/src/geometry/test_geometry.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 1898 to 1976, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.