Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use aws codebuild #8498

Merged
merged 6 commits into from
Aug 20, 2024
Merged

ci: use aws codebuild #8498

merged 6 commits into from
Aug 20, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Aug 15, 2024

Description

Following:

Relevant machines:

Instance Type Memory vCPUs Price per Minute
arm1.large 16 GiB 8 $0.015
general1.medium 7 GB 4 $0.01
general1.large 15 GB 8 $0.02
general1.xlarge 72 GiB 36 $0.0798
  • all tests will use total cpu count - 1 cores to build, to allow runner to function.
    • right now the taskset cpu count is provided manually, can be made into a simple workflow step in the future
    • otherwise machines lose connection
    • we make use of taskset from GNU coreutils for this job
  • build-and-test will use general1.medium since it is not time critical and it's ok for it to be slow
    • It exceeded 2 hours with just 3 cores so switching it to large now.
  • build-and-test-daily-arm64 will use arm1.large
    • it runs once per day so it's alright to have large machine
  • build-and-test-differential-arm64 will use arm1.large
    • this workflow requires arm tag and is not required for merging, will rarely be used
  • build-and-test-differential will use general1.large
    • in the future we can optimize it so that:
      • building is done on general1.xlarge
        • building is parallel-friendly and we are charged per cpu/minutes so this would make it finish much faster with similar price
      • test and codecov upload is done on a general1.medium
        • tests are running sequentially, more than 4 cores is wasted with these tests
        • codecov could even run on github hosted runners

Related links

Private Links:

Tests

Old tests

https://docs.google.com/spreadsheets/d/1hO7rxgq_cYAoAEc7EWOFs-e_fwxeTwTJOBznAtBkPac/edit?usp=sharing

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@xmfcx xmfcx marked this pull request as draft August 15, 2024 17:41
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Aug 15, 2024
@xmfcx xmfcx requested a review from mitsudome-r August 15, 2024 17:41
Copy link

github-actions bot commented Aug 15, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.86%. Comparing base (7424c48) to head (5c54dc7).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8498      +/-   ##
==========================================
- Coverage   23.91%   23.86%   -0.05%     
==========================================
  Files        1381     1383       +2     
  Lines      101939   102005      +66     
  Branches    38822    38845      +23     
==========================================
- Hits        24376    24346      -30     
- Misses      75119    75187      +68     
- Partials     2444     2472      +28     
Flag Coverage Δ *Carryforward flag
differential 19.06% <ø> (?) Carriedforward from 4aa70ff
total 23.87% <ø> (-0.05%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx xmfcx self-assigned this Aug 16, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Aug 16, 2024

the test errors were probably caused by somewhere here:

@xmfcx xmfcx added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 19, 2024
@xmfcx xmfcx force-pushed the ci/test-aws-codebuild branch 2 times, most recently from 5cf3650 to a095d61 Compare August 19, 2024 09:33
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Aug 19, 2024
@xmfcx xmfcx changed the title ci: test aws codebuild ci: use aws codebuild Aug 20, 2024
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
@xmfcx xmfcx added the type:arm64 ARM64 architecture issues or compatibility. label Aug 20, 2024
Signed-off-by: M. Fatih Cırıt <[email protected]>
@github-actions github-actions bot removed the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Aug 20, 2024
@xmfcx xmfcx marked this pull request as ready for review August 20, 2024 12:54
xmfcx and others added 2 commits August 20, 2024 18:07
@xmfcx xmfcx merged commit bd628e4 into main Aug 20, 2024
24 of 25 checks passed
@xmfcx xmfcx deleted the ci/test-aws-codebuild branch August 20, 2024 16:50
@xmfcx
Copy link
Contributor Author

xmfcx commented Aug 20, 2024

@mitsudome-r I've merged it. If something goes wrong, feel free to revert this change.

But before reverting, please link the failing CI reports under here and try to rerun them at least once.

I will keep the old machines alive for 1 more week. And if things go smoothly, I will terminate them.

@isamu-takagi
Copy link
Contributor

isamu-takagi commented Aug 21, 2024

@xmfcx @mitsudome-r cc: @yhisaki

It seems that the README added in this PR overrides the README in the repository root.
https://github.com/autowarefoundation/autoware.universe?tab=readme-ov-file

If a repository contains more than one README file, then the file shown is chosen from locations in the following order: the .github directory, then the repository's root directory, and finally the docs directory.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes

kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:arm64 ARM64 architecture issues or compatibility. type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants