Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(colcon-build): nice-command to build-pre-command #310

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Aug 20, 2024

Description

This PR tries to limit the number of CPUs used by the runner.

But instead of using the usual --parallel-workers 3 or MAKEFLAGS=-j4 that limit the ways we can pick how many cores are assigned, we can also make use of taskset --cpu-list 0-4 colcon build ... which will use first 5 cores.

Since we already added the nice-command as a pre-command for the colcon build, let's generalize it so we can use it with this purpose as well.

Related:

Tests performed

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx requested a review from mitsudome-r August 20, 2024 09:07
@xmfcx xmfcx self-assigned this Aug 20, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Aug 20, 2024

@xmfcx xmfcx marked this pull request as ready for review August 20, 2024 09:26
@xmfcx xmfcx merged commit f95438f into main Aug 20, 2024
15 of 17 checks passed
@xmfcx xmfcx deleted the refactor/rename-nice-command branch August 20, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant