-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(geo_pose_projector)!: prefix package and namespace with autoware #8334
refactor(geo_pose_projector)!: prefix package and namespace with autoware #8334
Conversation
Signed-off-by: a-maumau <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8334 +/- ##
==========================================
- Coverage 23.74% 0.00% -23.75%
==========================================
Files 1379 14 -1365
Lines 101365 168 -101197
Branches 38524 18 -38506
==========================================
- Hits 24066 0 -24066
+ Misses 74802 168 -74634
+ Partials 2497 0 -2497
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that logging_simulator and AWSIM work.
Also, I checked
-
Directory Name
- Add
autoware_
as a prefix to the directory name.
- Add
-
packages.xml
- Add
autoware_
to thename
element.
- Add
-
CMakeLists.txt
- Change the
project
name toautoware_***
. - Add
autoware::
toPLUGIN
.
- Change the
-
Header Files (.hpp)
- Add
autoware::
tonamespace
.
- Add
-
Source Files (.cpp)
- Add
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.
- Add
-
Launch Files
- Add
autoware_
beforefind-pkg-share
. - Change
node pkg="<pkgname>"
toautoware_<pkgname>
.
- Add
-
Include
- Add
autoware
folder as necessary and update include statements accordingly. - Check for impacts on other packages.
- Add
-
Verification Points
- Search
find-pkg-share
in autoware - Check README file (especially json schema)
- Pay attention to complex cases like
sensor_launch
as seen ingnss_poser
- Search
c67141f
into
autowarefoundation:main
…ware (autowarefoundation#8334) * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <[email protected]>
…ware (autowarefoundation#8334) * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <[email protected]>
…ware (autowarefoundation#8334) * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <[email protected]>
…ware (autowarefoundation#8334) * add autoware_ prefix Signed-off-by: a-maumau <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: a-maumau <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SakodaShintaro <[email protected]> Signed-off-by: xtk8532704 <[email protected]>
Description
This PR will add a
autoware_
prefix togeo_pose_projector
.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.