Skip to content

Commit

Permalink
refactor(geo_pose_projector)!: prefix package and namespace with auto…
Browse files Browse the repository at this point in the history
…ware (#8334)

* add autoware_ prefix

Signed-off-by: a-maumau <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: a-maumau <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: SakodaShintaro <[email protected]>
  • Loading branch information
3 people authored Aug 9, 2024
1 parent 8c5a24b commit c67141f
Show file tree
Hide file tree
Showing 11 changed files with 18 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ localization/autoware_pose_covariance_modifier/** [email protected]
localization/autoware_stop_filter/** [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
localization/autoware_twist2accel/** [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
localization/ekf_localizer/** [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
localization/geo_pose_projector/** [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
localization/autoware_geo_pose_projector/** [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
localization/gyro_odometer/** [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
localization/localization_error_monitor/** [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
localization/localization_util/** [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
<include file="$(find-pkg-share eagleye_geo_pose_fusion)/launch/geo_pose_fusion.launch.xml">
<arg name="output_geo_pose" value="$(var geo_pose_topic_name)"/>
</include>
<include file="$(find-pkg-share geo_pose_projector)/launch/geo_pose_projector.launch.xml">
<include file="$(find-pkg-share autoware_geo_pose_projector)/launch/geo_pose_projector.launch.xml">
<arg name="input_geo_pose" value="$(var geo_pose_topic_name)"/>
<arg name="output_pose" value="$(var output_pose_with_cov_name)"/>
</include>
Expand Down
2 changes: 1 addition & 1 deletion launch/tier4_localization_launch/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@

<exec_depend>automatic_pose_initializer</exec_depend>
<exec_depend>autoware_ar_tag_based_localizer</exec_depend>
<exec_depend>autoware_geo_pose_projector</exec_depend>
<exec_depend>autoware_pointcloud_preprocessor</exec_depend>
<exec_depend>eagleye_geo_pose_fusion</exec_depend>
<exec_depend>eagleye_gnss_converter</exec_depend>
<exec_depend>eagleye_rt</exec_depend>
<exec_depend>ekf_localizer</exec_depend>
<exec_depend>geo_pose_projector</exec_depend>
<exec_depend>gyro_odometer</exec_depend>
<exec_depend>ndt_scan_matcher</exec_depend>
<exec_depend>pose_estimator_arbiter</exec_depend>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cmake_minimum_required(VERSION 3.14)
project(geo_pose_projector)
project(autoware_geo_pose_projector)

find_package(autoware_cmake REQUIRED)
autoware_package()
Expand All @@ -9,7 +9,7 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
)

rclcpp_components_register_node(${PROJECT_NAME}
PLUGIN "GeoPoseProjector"
PLUGIN "autoware::geo_pose_projector::GeoPoseProjector"
EXECUTABLE ${PROJECT_NAME}_node
EXECUTOR SingleThreadedExecutor
)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# geo_pose_projector
# autoware_geo_pose_projector

## Overview

Expand All @@ -20,7 +20,7 @@ This node is a simple node that subscribes to the geo-referenced pose topic and

## Parameters

{{ json_to_markdown("localization/geo_pose_projector/schema/geo_pose_projector.schema.json") }}
{{ json_to_markdown("localization/autoware_geo_pose_projector/schema/geo_pose_projector.schema.json") }}

## Limitations

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
<launch>
<arg name="input_geo_pose" default="/geo_pose_with_covariance"/>
<arg name="output_pose" default="/pose_with_covariance"/>
<arg name="param_path" default="$(find-pkg-share geo_pose_projector)/config/geo_pose_projector.param.yaml"/>
<arg name="param_path" default="$(find-pkg-share autoware_geo_pose_projector)/config/geo_pose_projector.param.yaml"/>

<node pkg="geo_pose_projector" exec="geo_pose_projector_node" output="both">
<node pkg="autoware_geo_pose_projector" exec="autoware_geo_pose_projector_node" output="both">
<remap from="input_geo_pose" to="$(var input_geo_pose)"/>
<remap from="output_pose" to="$(var output_pose)"/>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>geo_pose_projector</name>
<name>autoware_geo_pose_projector</name>
<version>0.1.0</version>
<description>The geo_pose_projector package</description>
<description>The autoware_geo_pose_projector package</description>
<maintainer email="[email protected]">Yamato Ando</maintainer>
<maintainer email="[email protected]">Masahiro Sakamoto</maintainer>
<maintainer email="[email protected]">Kento Yabuuchi</maintainer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@

#include <string>

namespace autoware::geo_pose_projector
{
GeoPoseProjector::GeoPoseProjector(const rclcpp::NodeOptions & options)
: rclcpp::Node("geo_pose_projector", options), publish_tf_(declare_parameter<bool>("publish_tf"))
{
Expand Down Expand Up @@ -102,6 +104,7 @@ void GeoPoseProjector::on_geo_pose(const GeoPoseWithCovariance::ConstSharedPtr m
tf_broadcaster_->sendTransform(transform_stamped);
}
}
} // namespace autoware::geo_pose_projector

#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(GeoPoseProjector)
RCLCPP_COMPONENTS_REGISTER_NODE(autoware::geo_pose_projector::GeoPoseProjector)
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
#include <optional>
#include <string>

namespace autoware::geo_pose_projector
{
class GeoPoseProjector : public rclcpp::Node
{
private:
Expand All @@ -54,5 +56,6 @@ class GeoPoseProjector : public rclcpp::Node
std::string parent_frame_;
std::string child_frame_;
};
} // namespace autoware::geo_pose_projector

#endif // GEO_POSE_PROJECTOR_HPP_

0 comments on commit c67141f

Please sign in to comment.