Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(detected_object_validation): rework parameters #7750

Conversation

batuhanbeytekin
Copy link
Member

@batuhanbeytekin batuhanbeytekin commented Jun 28, 2024

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371

Tests performed

Package built and launch locally.

Effects on system behavior

More reliable and faster parameter configuration file creation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR follows the pull request guidelines.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@batuhanbeytekin batuhanbeytekin added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) DevOps Dojo: ROS Node Conf Related to Open AD Kit WG tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 28, 2024
@batuhanbeytekin batuhanbeytekin self-assigned this Jun 28, 2024
Copy link

github-actions bot commented Jun 28, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@batuhanbeytekin batuhanbeytekin force-pushed the batu/detected_object_validation branch 3 times, most recently from a376915 to a2096fb Compare June 28, 2024 12:11
@batuhanbeytekin batuhanbeytekin added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 28.00%. Comparing base (fc283c5) to head (e661cf8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t_validation/src/lanelet_filter/lanelet_filter.cpp 0.00% 8 Missing ⚠️
...ccupancy_grid_map/occupancy_grid_map_validator.cpp 0.00% 2 Missing ⚠️
...tacle_pointcloud/obstacle_pointcloud_validator.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7750      +/-   ##
==========================================
- Coverage   28.00%   28.00%   -0.01%     
==========================================
  Files        1317     1317              
  Lines       98578    98585       +7     
  Branches    39776    39779       +3     
==========================================
  Hits        27605    27605              
- Misses      70874    70881       +7     
  Partials       99       99              
Flag Coverage Δ *Carryforward flag
differential 6.35% <52.17%> (?)
total 27.99% <ø> (-0.01%) ⬇️ Carriedforward from fc283c5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@batuhanbeytekin batuhanbeytekin force-pushed the batu/detected_object_validation branch from d45cef6 to 47eb566 Compare July 8, 2024 16:00
@mitsudome-r
Copy link
Member

@batuhanbeytekin It seems like there is a conflict with main branch. Could you resolve the conflicts?

@batuhanbeytekin batuhanbeytekin force-pushed the batu/detected_object_validation branch from 47eb566 to 419ea47 Compare July 12, 2024 11:31
@batuhanbeytekin
Copy link
Member Author

@batuhanbeytekin It seems like there is a conflict with main branch. Could you resolve the conflicts?

Hi @mitsudome-r, my branch is up to date. I think the conflict has been resolved now. Thank you for your reply.

<launch>
<arg name="object_position_filter_param_file" default="$(find-pkg-share detected_object_validation)/config/object_position_filter.param.yaml"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any reasons for changing the argument name? Is it to match the name with parameter file name?
Since these arguments could be used by other launch files, it might be better to keep it the same for now. We could fix them when we refactor launch files after parameter work is done. (The same goes for other launch argument names)

Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@batuhanbeytekin
Please resolve conflicts.

@batuhanbeytekin batuhanbeytekin force-pushed the batu/detected_object_validation branch 5 times, most recently from f173d86 to 87c26bc Compare August 16, 2024 12:01
@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 20, 2024
batuhanbeytekin and others added 10 commits September 20, 2024 13:57
Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
…lter.schema.json

Co-authored-by: badai nguyen  <[email protected]>

Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
…ilter.schema.json

Co-authored-by: badai nguyen  <[email protected]>

Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: batuhanbeytekin <[email protected]>

Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
@github-actions github-actions bot removed component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Sep 20, 2024
@MasatoSaeki MasatoSaeki merged commit 6465aaf into autowarefoundation:main Sep 20, 2024
31 of 32 checks passed
@MasatoSaeki
Copy link
Contributor

@batuhanbeytekin
If you want to capture progress of main branch, you can use update branch button. It is easy to do that and. (It looked like you made mistakes when rebase)
And you do not need to assign reviewer who is not related. It only confuses related people.
image

MasatoSaeki pushed a commit to tier4/autoware.universe that referenced this pull request Sep 20, 2024
…dation#7750)

* refactor(detected_object_validation): rework parameters

Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Batuhan Beytekin <[email protected]>

* Update perception/detected_object_validation/schema/object_lanelet_filter.schema.json

Co-authored-by: badai nguyen  <[email protected]>

Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>

* Update perception/detected_object_validation/schema/object_position_filter.schema.json

Co-authored-by: badai nguyen  <[email protected]>

Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>

* refactor(detected_object_validation): rework parameters

Signed-off-by: batuhanbeytekin <[email protected]>

Signed-off-by: Batuhan Beytekin <[email protected]>

* refactor(detected_object_validation): rework parameters

Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>

* refactor(detected_object_validation): rework parameters

Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>

* style(pre-commit): autofix

Signed-off-by: Batuhan Beytekin <[email protected]>

* refactor(detected_object_validation): rework parameters

Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>

* refactor(detected_object_validation): rework parameters

Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: batuhanbeytekin <[email protected]>
Signed-off-by: Batuhan Beytekin <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
rej55 added a commit to tier4/autoware.universe that referenced this pull request Sep 24, 2024
refactor(detected_object_validation): rework parameters (autowarefoundation#7750)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) DevOps Dojo: ROS Node Conf Related to Open AD Kit WG tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Development

Successfully merging this pull request may close these issues.

6 participants