Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(client/electron/windows): delete unused find_tap_name #1957

Merged
merged 2 commits into from
Apr 5, 2024
Merged

build(client/electron/windows): delete unused find_tap_name #1957

merged 2 commits into from
Apr 5, 2024

Conversation

fortuna
Copy link
Collaborator

@fortuna fortuna commented Apr 5, 2024

It was removed in #756

@fortuna fortuna requested a review from jyyi1 April 5, 2024 17:14
@fortuna fortuna requested a review from a team as a code owner April 5, 2024 17:14
@github-actions github-actions bot added the size/M label Apr 5, 2024
@fortuna fortuna changed the title build(electron/windows): delete unused find_tap_name build(client/electron/windows): delete unused find_tap_name Apr 5, 2024
jyyi1
jyyi1 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fortuna fortuna merged commit db98df4 into master Apr 5, 2024
21 of 22 checks passed
@fortuna fortuna deleted the fortuna-tapname branch April 5, 2024 18:10
daniellacosse pushed a commit that referenced this pull request Apr 10, 2024
@fortuna @daniellacosse
build(client/electron/windows): delete unused find_tap_name (#1957)
592c9d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fortuna @jyyi1