Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(client/electron/windows): delete unused find_tap_name #1957

Merged
merged 2 commits into from
Apr 5, 2024
Merged

build(client/electron/windows): delete unused find_tap_name #1957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ee4f76
Delete unused find_tap_name
fortuna Apr 5, 2024
ec1a57a
Add history
fortuna Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed client/tools/find_tap_name/bin/386/find_tap_name.exe
View file
Open in desktop
Binary file not shown.
Binary file removed client/tools/find_tap_name/bin/amd64/find_tap_name.exe
View file
Open in desktop
Binary file not shown.
20 changes: 0 additions & 20 deletions client/tools/find_tap_name/build.action.sh
View file
Open in desktop

This file was deleted.

172 changes: 0 additions & 172 deletions client/tools/find_tap_name/main.go
View file
Open in desktop

This file was deleted.

8 changes: 7 additions & 1 deletion src/electron/find_tap_device_name.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@
:: Queries the registry in order to retrieve the most recently installed TAP network adapter's name.
:: Accepts a single argument, the name of an environment variable to store the adapter's name.
:: Exits with a non-zero exit code on failure.
:: Usage example: find_tap_name.bat TAP_NAME
:: Usage example: find_tap_device_name.bat TAP_NAME

:: Some history:
:: We used to use a Go binary for this to improve the name detection:
:: https://github.com/Jigsaw-Code/outline-apps/pull/711
:: It was later replaced by this script "following reports that the Go binaries fail to run on some environments":
:: https://github.com/Jigsaw-Code/outline-apps/pull/756

@echo off
:: See https://ss64.com/nt/delayedexpansion.html
Expand Down
Loading