build(client/electron/windows): delete unused find_tap_name (#1957)

Jigsaw-Code · Apr 5, 2024 · db98df4 · db98df4
1 parent 341e6d7
commit db98df4
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 193 deletions.
diff --git a/client/tools/find_tap_name/bin/386/find_tap_name.exe b/client/tools/find_tap_name/bin/386/find_tap_name.exe
diff --git a/client/tools/find_tap_name/bin/amd64/find_tap_name.exe b/client/tools/find_tap_name/bin/amd64/find_tap_name.exe
diff --git a/client/tools/find_tap_name/build.action.sh b/client/tools/find_tap_name/build.action.sh
diff --git a/client/tools/find_tap_name/main.go b/client/tools/find_tap_name/main.go
diff --git a/src/electron/find_tap_device_name.bat b/src/electron/find_tap_device_name.bat
@@ -15,7 +15,13 @@
 :: Queries the registry in order to retrieve the most recently installed TAP network adapter's name.
 :: Accepts a single argument, the name of an environment variable to store the adapter's name.
 :: Exits with a non-zero exit code on failure.
-:: Usage example: find_tap_name.bat TAP_NAME
+:: Usage example: find_tap_device_name.bat TAP_NAME
+
+:: Some history:
+:: We used to use a Go binary for this to improve the name detection:
+:: https://github.com/Jigsaw-Code/outline-apps/pull/711
+:: It was later replaced by this script "following reports that the Go binaries fail to run on some environments":
+:: https://github.com/Jigsaw-Code/outline-apps/pull/756
 
 @echo off
 :: See https://ss64.com/nt/delayedexpansion.html