replace plugins versions withe commit hash #3212
Conversation
.github/workflows/main.yml
Outdated
| @@ -61,17 +61,17 @@ jobs: | |||
| # so, seperating steps with if conditions | |||
| - name: build ROS2 for foxy | |||
| if: ${{ matrix.ros_distro == 'foxy' }} | |||
| uses: ros-tooling/[email protected] | |||
| uses: ros-tooling/setup-ros@0395475ab6416edc274bb3c43673b2091a217e02 #v0.6 | |||
There was a problem hiding this comment.
since I saw failures in the FOXY distro, I think this hash is the reasons.
I think it should be replaced with this hash:
236ab287884fd5a314fc030e91b2017abb46719e
See: https://github.com/ros-tooling/setup-ros/commits/v0.6/
There was a problem hiding this comment.
changed it to 236ab287884fd5a314fc030e91b2017abb46719e (v0.6 0.6.3)
| @@ -13,7 +13,7 @@ jobs: | |||
| name: cppcheck | |||
| runs-on: ubuntu-22.04 | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 #v3 | |||
There was a problem hiding this comment.
I think we can use checkout v4 here with the hash: 692973e3d937129bcbf40652eb9f2f61becf3332
as we are already using v4 in other files..
|
closing and reopening to trigger LRS_rosci_trigger |
| @@ -61,17 +61,17 @@ jobs: | |||
| # so, seperating steps with if conditions | |||
| - name: build ROS2 for foxy | |||
| if: ${{ matrix.ros_distro == 'foxy' }} | |||
| uses: ros-tooling/[email protected] | |||
| uses: ros-tooling/setup-ros@236ab287884fd5a314fc030e91b2017abb46719e #v0.6 | |||
There was a problem hiding this comment.
Where did you get this hash from?
I see here a different one
https://github.com/ros-tooling/setup-ros/releases/tag/v0.6
There was a problem hiding this comment.
I see where from,
You use 0.63,
Let's try 0.6 as 0.63 failed
There was a problem hiding this comment.
At first I put 0395475ab6416edc274bb3c43673b2091a217e02 (V0.6) and that caused problems with the FOXY distro.
So I changed it to 236ab287884fd5a314fc030e91b2017abb46719e (0.6.3 last commit on v0.6)
SamerKhshiboun
merged commit c786902
into
IntelRealSense:ros2-development
Tracked by: LRS-1187