lightbox: Replace onDismiss with await showErrorDialog
#937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIG208
force-pushed
the
pr-lightbox-dialog
branch
from
7d18cfa
to
0bae716
Compare
|
LGTM assuming you've tested this manually; marking for Greg's review. |
chrisbobbe
added
integration review
chrisbobbe
requested review from
gnprice
and removed request for
chrisbobbe
|
I forgot to mention that this shouldn't be an nfc change, because the user can close the dialog by tapping the barrier now. Pushed an update to the commit message to reflect that. |
PIG208
force-pushed
the
pr-lightbox-dialog
branch
from
0bae716
to
b088e39
Compare
|
Makes sense. Ah and I think |
PIG208
force-pushed
the
pr-lightbox-dialog
branch
from
b088e39
to
f27b62c
Compare
`showDialog` returns a `Future` that resolves when the dialog is dismissed. This refactors `showErrorDialog` to stop overriding `onPressed` and `barrierDismissible`, and make the caller call `Navigator.pop` one more time once the dialog is closed. This is not an nfc because now the user can tap the barrier (darkened area around the dialog) to close it. Note that we check for `mounted` again because there has been an asynchronous gap. See also: zulip#587 (comment) Signed-off-by: Zixuan James Li <[email protected]>
PIG208
force-pushed
the
pr-lightbox-dialog
branch
from
f27b62c
to
1df1035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showDialogreturns aFuturethat resolves when the dialog is dismissed.This refactors
showErrorDialogto stop overridingonPressedandbarrierIsDismissable, and make the caller call Navigator.pop one more time once the dialog is closed.Note that we check for
mountedagain because there has been an asynchronous gap.See also:
#587 (comment)