-
Notifications
You must be signed in to change notification settings - Fork 134
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
lightbox: Replace onDismiss with
await showErrorDialog
`showDialog` returns a `Future` that resolves when the dialog is dismissed. This refactors `showErrorDialog` to stop overriding `onPressed` and `barrierDismissible`, and make the caller call Navigator.pop one more time once the dialog is closed. This is not an nfc because now the user can tap the barrier (darkened area around the dialog) to close it. Note that we check for `mounted` again because there has been an asynchronous gap. See also: #587 (comment) Signed-off-by: Zixuan James Li <[email protected]>
- Loading branch information
Showing
2 changed files
with
13 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters