Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32f7: Fix TX timestamp check #232

Merged
merged 2 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions stm32cube/stm32f7xx/README
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,11 @@ Patch List:
Impacted files:
drivers/include/Legacy/stm32_hal_legacy.h

*Fix: Use the correct register DESC0
This fix ensures that the TX timestamp is properly set by correctly
checking the ETH_DMATXDESC_LS and ETH_DMATXDESC_TTSS flags in the DESC0 register.
Impacted files:
stm32cube/stm32f7xx/drivers/src/stm32f7xx_hal_eth.c
ST Internal reference: 185461

marwaiehm-st marked this conversation as resolved.
Show resolved Hide resolved
See release_note.html from STM32Cube
4 changes: 2 additions & 2 deletions stm32cube/stm32f7xx/drivers/src/stm32f7xx_hal_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -1472,8 +1472,8 @@ HAL_StatusTypeDef HAL_ETH_ReleaseTxPacket(ETH_HandleTypeDef *heth)
if ((heth->Init.TxDesc[idx].DESC0 & ETH_DMATXDESC_OWN) == 0U)
{
#ifdef HAL_ETH_USE_PTP
if ((heth->Init.TxDesc[idx].DESC3 & ETH_DMATXDESC_LS)
&& (heth->Init.TxDesc[idx].DESC3 & ETH_DMATXDESC_TTSS))
if ((heth->Init.TxDesc[idx].DESC0 & ETH_DMATXDESC_LS)
&& (heth->Init.TxDesc[idx].DESC0 & ETH_DMATXDESC_TTSS))
{
/* Get timestamp low */
timestamp->TimeStampLow = heth->Init.TxDesc[idx].DESC6;
Expand Down
Loading