STM32f7: Fix TX timestamp check #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartben
approved these changes
Sep 4, 2024
|
Thanks for the fix, which looks totally fine. |
marwaiehm-st
force-pushed
the
fix_ptp_f7
branch
from
166e42e
to
b39dba6
Compare
|
@marwaiehm-st Please make an zephyr branch related to this PR. As we'll need to get it backported, it will likely be required in the process at one moment. |
FRASTM
approved these changes
Sep 10, 2024
mathieuchopstm
approved these changes
Sep 10, 2024
It looks like the original code was a bad copy-paste from H5/H7 HALs. ETH_DMATXDESC_LS and ETH_DMATXDESC_TTSS are flags from the DuESC0 register. This fix allows to effectively set the TX timestamp properly when there is one. Signed-off-by: Benjamin Cabé <[email protected]>
Update README file with the new patch "Use the correct register DESC0" Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
marwaiehm-st
force-pushed
the
fix_ptp_f7
branch
from
b39dba6
to
c6c31be
Compare
|
PR rebased |
erwango
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix ensures that the TX timestamp is properly set by correctly
checking the ETH_DMATXDESC_LS and ETH_DMATXDESC_TTSS flags in the DESCO register.
Fixes STMicroelectronics/STM32CubeF7#121