Closes issue #222. Autoplay of suggested next video. Button toggle. Does not play duplicates by maintaining history of all videos. #231

cipher1729 · 2016-07-29T09:23:35Z

Provide a general summary of your changes in the Title above.

Important

Mark with [x] to select. Leave as [ ] to unselect.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, include the text Closes #1 (where 1 would be the issue number) to your commit message.
Closes Autoplay Feature from Youtube #222

Types of changes

What types of changes does your code introduce? Check all the boxes that apply:

Bug fix (non-breaking change which fixes an issue)
[ x] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Description

Describe your changes in detail.
Added an autoplay button with two states - 'start autoplay' and 'stop autoplay'. With autoplay ON, similar videos keep playing one after the other. 'stop autoplay' disables this feature. History of videos played till now is stored and accessed from local session storage.

Final checklist:

Go over all the following points and check all the boxes that apply
If you're unsure about any of these, don't hesitate to ask. We're here to help!

[x ] My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
[x ] I have read the CONTRIBUTING guidelines.
All tests passed.

Last two tests "Demo" and "Form" fail - they complain about actions performed on null DOM objects. Maybe it has something to do with the order the player components and the page itself are loaded. The Demo still works, if the button is clicked manually.

Closes zen-audio-player#193 Add support for linking to a specific time position

…er.github.io

…video. History also maintained of all videos played to avoid duplicates

shakeelmohamed · 2016-07-30T05:58:53Z

js/everything.js

+var playList = [];
+var autoplayState;
+
+


nit: too many blank lines

shakeelmohamed · 2016-07-30T06:32:56Z

Thanks for the efforts here @cipher1729!

Last two tests "Demo" and "Form" fail - they complain about actions performed on null DOM objects. Maybe it has something to do with the order the player components and the page itself are loaded. The Demo still works, if the button is clicked manually.

If these tests are failing, functionality is broken.

~~I will update the eslint settings to catch some of the style issues I commented on~~ (edit: done)
Maybe we should be using window.localStorage instead, this will persist the playlist a bit longer - if so we need an easy way to purge the playlist information.
I think we shouldn't write to either storage more than once per function as there's a (relatively low) performance cost, but more importantly it will bloat the code.
Since we're using multiple window.sessionStorage keys, I think it might be cleaner to just use 1 key for playlist information and serialize a more detailed JSON object. Intuitively, something like the following seems reasonable:

{
    "items": [
        {
            "type": "youtube",
            "id": "12345678911",
            "played": false
        }
    ],
    "autoplaying": false
}

I'm always open to suggestions 💭

cipher1729 · 2016-08-02T06:16:47Z

Thanks for the feedback @shakeelmohamed . I'll try to fix issues asap

shakeelmohamed · 2016-08-02T17:00:59Z

js/everything.js

@@ -580,32 +573,32 @@ $(function() {
    // How do we know if the value is truly invalid?
    // Preload the form from the URL
    var currentVideoID = getCurrentVideoID();
-    if (currentVideoID) {
+    if (currentVideoID)
+    {


Please put the brace at the end of the previous line (with a space after the ))

…" : "true"/"false" , items=[ {"type":"youtube", "id":videoId, "played":true}, ... ] }

shakeelmohamed · 2016-08-09T04:10:35Z

js/everything.js

+        $("#toggleAutoplay").click(function(event)
+        {
+            var toggleTextElement = $("#" + event.currentTarget.id);
+            if (autoplayState === null)


This code can be simplified by using an if condition of !!autoplayState which converts the value to a boolean, null will evaluate to false.

ie:

> var vals = [null, false, true]; undefined > for (var v in vals) { console.log(!!vals[v]); } false false true

I like your logic but eslint complains: "Redundant double negation"

In that case, just use autoplayState as the condition. The same boolean rules will apply inside an if/loop condition

shakeelmohamed · 2016-08-09T04:43:43Z

I've made some additional eslint changes, please merge in the latest master branch. This will catch many of the style-related things I would've commented on

…er.github.io

cipher1729 · 2016-08-10T07:17:14Z

I think i've incorporated all changes

shakeelmohamed · 2016-08-11T04:12:33Z

js/everything.js

                toggleTextElement.text("Stop autoplay");
            }
            else {
-                if (autoplayState === "true")
-                {
+                if (autoplayState === true) {


don't need to compare a truthy value to true, it can just be if (autoplayState) {

shakeelmohamed

@cipher1729 ping 😃

cipher1729 · 2016-09-17T16:59:51Z

Hey @shakeelmohamed , sorry been crazy busy, will get back to this asap

Cleaned up the code from pull request zen-audio-player#231. Then fixed some bugs: (1) Fixed getNewVideoID function. Previously it just popped up all the playList and left only the first element. And if this element would be current video id then nextId will be set to null. Now I've made a reverse for playlist array to get just the same next video from YouTube as Youtube suggests itself and that is done with no further changes in the code. I've also removed the while loop from getNewVideoID function and that gives the code an opportunity to check all the playlist for a next track during the session. (2) Fixed the problem when tracks were added to videoMetadata["items"] when they were already there. Now there is a clause that checks if current track has already been played and if so just doesn't add a duplicate.

shakeelmohamed · 2019-02-13T05:59:26Z

Closing due to inactivity

shakeelmohamed and others added 4 commits July 29, 2016 04:38

Merge pull request zen-audio-player#206 from hjh17/master

4549f7b

Closes zen-audio-player#193 Add support for linking to a specific time position

Merge branch 'master' of https://github.com/cipher1729/zen-audio-play…

916dd50

…er.github.io

Towards issue zen-audio-player#222. Has GUI toggle for autoplay next …

1026b55

…video. History also maintained of all videos played to avoid duplicates

minor fix

cde5acf

shakeelmohamed reviewed Jul 30, 2016
View reviewed changes

js/everything.js

var playList = [];

var autoplayState;

Copy link

Member

shakeelmohamed Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: too many blank lines

shakeelmohamed added question/discussion in progress labels Jul 30, 2016

cipher1729 added 4 commits August 2, 2016 01:00

tests passing. indentation fixed

3e30725

indentation fix

3818069

indentation fix

503f727

Merge branch 'master' into master

67c9314

shakeelmohamed reviewed Aug 2, 2016
View reviewed changes

cipher1729 added 2 commits August 3, 2016 23:38

Merge branch 'master' into master

da3179a

Video meta data organized as an object of the form : { "autoplayState…

ca43a82

…" : "true"/"false" , items=[ {"type":"youtube", "id":videoId, "played":true}, ... ] }

shakeelmohamed reviewed Aug 9, 2016
View reviewed changes

cipher1729 added 4 commits August 8, 2016 23:43

Merge branch 'master' into master

eae6815

Merge with master

370c3a3

code reorganized

98aca5e

Merge branch 'master' of https://github.com/cipher1729/zen-audio-play…

cfe7c6b

…er.github.io

shakeelmohamed reviewed Aug 11, 2016
View reviewed changes

shakeelmohamed requested changes Sep 15, 2016

View reviewed changes

Merge branch 'master' into master

21912a0

shakeelmohamed added up for grabs hacktoberfest labels Oct 3, 2016

avalan4e57 mentioned this pull request Jul 28, 2017

Closes Issue #222: Autoplay Feature from Youtube #258

Closed

8 tasks

shakeelmohamed added needs work and removed in progress labels Oct 16, 2017

shakeelmohamed closed this Feb 13, 2019

shakeelmohamed mentioned this pull request Jul 12, 2019

Autoplay Feature from Youtube #222

Open

k----n mentioned this pull request Oct 8, 2019

Closes #222 Autoplay the next related video #329

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Closes issue #222. Autoplay of suggested next video. Button toggle. Does not play duplicates by maintaining history of all videos. #231

Closes issue #222. Autoplay of suggested next video. Button toggle. Does not play duplicates by maintaining history of all videos. #231

cipher1729 commented Jul 29, 2016

shakeelmohamed Jul 30, 2016

shakeelmohamed commented Jul 30, 2016 •

edited

Loading

cipher1729 commented Aug 2, 2016 •

edited

Loading

shakeelmohamed Aug 2, 2016

shakeelmohamed Aug 9, 2016

cipher1729 Aug 9, 2016

shakeelmohamed Aug 9, 2016

shakeelmohamed commented Aug 9, 2016

cipher1729 commented Aug 10, 2016

shakeelmohamed Aug 11, 2016

shakeelmohamed left a comment

cipher1729 commented Sep 17, 2016

shakeelmohamed commented Feb 13, 2019

Closes issue #222. Autoplay of suggested next video. Button toggle. Does not play duplicates by maintaining history of all videos. #231

Closes issue #222. Autoplay of suggested next video. Button toggle. Does not play duplicates by maintaining history of all videos. #231

Conversation

cipher1729 commented Jul 29, 2016

Important

Motivation and Context

Types of changes

Description

Final checklist:

shakeelmohamed Jul 30, 2016

Choose a reason for hiding this comment

shakeelmohamed commented Jul 30, 2016 • edited Loading

cipher1729 commented Aug 2, 2016 • edited Loading

shakeelmohamed Aug 2, 2016

Choose a reason for hiding this comment

shakeelmohamed Aug 9, 2016

Choose a reason for hiding this comment

cipher1729 Aug 9, 2016

Choose a reason for hiding this comment

shakeelmohamed Aug 9, 2016

Choose a reason for hiding this comment

shakeelmohamed commented Aug 9, 2016

cipher1729 commented Aug 10, 2016

shakeelmohamed Aug 11, 2016

Choose a reason for hiding this comment

shakeelmohamed left a comment

Choose a reason for hiding this comment

cipher1729 commented Sep 17, 2016

shakeelmohamed commented Feb 13, 2019

shakeelmohamed commented Jul 30, 2016 •

edited

Loading

cipher1729 commented Aug 2, 2016 •

edited

Loading