Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #222 Autoplay the next related video #329

Closed
wants to merge 5 commits into from

Conversation

k----n
Copy link

@k----n k----n commented Oct 8, 2019

Motivation and Context

This pull request fixes the bug where it would autoplay whatever was in the search box, but might lead to search results in PR #258 . It uses code from PR #231 and #258.

Types of changes

What types of changes does your code introduce? Check all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes PR #258 bug that autoplays the next query in the search box.
Instead, the next song that is related plays instead.

Final checklist:

Go over all the following points and check all the boxes that apply
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING guidelines.
  • All tests passed.

@k----n
Copy link
Author

k----n commented Oct 8, 2019

Although I do not agree with some of the design decisions, I will refactor the code when working on #229 .

js/everything.js Outdated Show resolved Hide resolved
@shakeelmohamed shakeelmohamed deleted the branch zen-audio-player:master August 9, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants