-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
issue-1795: implemented Unsafe{Delete,Update,Get}Node to use it in pr…
…ivate api for manual interventions - e.g. to clean up OrphanNodes (#2165) * issue-1795: implemented Unsafe{Delete,Update,Get}Node to use it in private api for manual interventions - e.g. to clean up OrphanNodes * issue-1795: tiny cleanup * issue-1795: private api Unsafe{Delete,Update,Get}Node actions + ut * issue-1795: cleanup
- Loading branch information
Showing
12 changed files
with
730 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
164 changes: 164 additions & 0 deletions
164
cloud/filestore/libs/storage/service/service_actor_actions_unsafe_node_ops.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,164 @@ | ||
| #include "service_actor.h" | ||
|
|
||
| #include <cloud/filestore/libs/storage/api/service.h> | ||
| #include <cloud/filestore/libs/storage/api/tablet.h> | ||
| #include <cloud/filestore/libs/storage/api/tablet_proxy.h> | ||
| #include <cloud/filestore/libs/storage/core/public.h> | ||
| #include <cloud/filestore/private/api/protos/tablet.pb.h> | ||
|
|
||
| #include <contrib/ydb/library/actors/core/actor_bootstrapped.h> | ||
|
|
||
| #include <google/protobuf/util/json_util.h> | ||
|
|
||
| namespace NCloud::NFileStore::NStorage { | ||
|
|
||
| using namespace NActors; | ||
|
|
||
| using namespace NKikimr; | ||
|
|
||
| namespace { | ||
|
|
||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| template <typename TRequest, typename TResponse> | ||
| class TTabletActionActor final | ||
| : public TActorBootstrapped<TTabletActionActor<TRequest, TResponse>> | ||
| { | ||
| private: | ||
| const TRequestInfoPtr RequestInfo; | ||
| const TString Input; | ||
|
|
||
| using TBase = TActorBootstrapped<TTabletActionActor<TRequest, TResponse>>; | ||
|
|
||
| public: | ||
| TTabletActionActor( | ||
| TRequestInfoPtr requestInfo, | ||
| TString input); | ||
|
|
||
| void Bootstrap(const TActorContext& ctx); | ||
|
|
||
| private: | ||
| void ReplyAndDie( | ||
| const TActorContext& ctx, | ||
| const TResponse::ProtoRecordType& responseRecord); | ||
|
|
||
| private: | ||
| STFUNC(StateWork) | ||
| { | ||
| switch (ev->GetTypeRewrite()) { | ||
| HFunc(TResponse, HandleResponse); | ||
|
|
||
| default: | ||
| HandleUnexpectedEvent(ev, TFileStoreComponents::SERVICE); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| void HandleResponse(const TResponse::TPtr& ev, const TActorContext& ctx); | ||
| }; | ||
|
|
||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| template <typename TRequest, typename TResponse> | ||
| TTabletActionActor<TRequest, TResponse>::TTabletActionActor( | ||
| TRequestInfoPtr requestInfo, | ||
| TString input) | ||
| : RequestInfo(std::move(requestInfo)) | ||
| , Input(std::move(input)) | ||
| {} | ||
|
|
||
| template <typename TRequest, typename TResponse> | ||
| void TTabletActionActor<TRequest, TResponse>::Bootstrap( | ||
| const TActorContext& ctx) | ||
| { | ||
| typename TRequest::ProtoRecordType request; | ||
| if (!google::protobuf::util::JsonStringToMessage(Input, &request).ok()) { | ||
| ReplyAndDie( | ||
| ctx, | ||
| TErrorResponse(E_ARGUMENT, "Failed to parse input")); | ||
| return; | ||
| } | ||
|
|
||
| if (!request.GetFileSystemId()) { | ||
| ReplyAndDie( | ||
| ctx, | ||
| TErrorResponse(E_ARGUMENT, "FileSystem id should be supplied")); | ||
| return; | ||
| } | ||
|
|
||
| auto requestToTablet = std::make_unique<TRequest>(); | ||
| requestToTablet->Record = std::move(request); | ||
|
|
||
| NCloud::Send( | ||
| ctx, | ||
| MakeIndexTabletProxyServiceId(), | ||
| std::move(requestToTablet)); | ||
|
|
||
| TBase::Become(&TTabletActionActor<TRequest, TResponse>::StateWork); | ||
| } | ||
|
|
||
| template <typename TRequest, typename TResponse> | ||
| void TTabletActionActor<TRequest, TResponse>::ReplyAndDie( | ||
| const TActorContext& ctx, | ||
| const TResponse::ProtoRecordType& response) | ||
| { | ||
| auto msg = std::make_unique<TEvService::TEvExecuteActionResponse>( | ||
| response.GetError()); | ||
|
|
||
| google::protobuf::util::MessageToJsonString( | ||
| response, | ||
| msg->Record.MutableOutput()); | ||
|
|
||
| NCloud::Reply(ctx, *RequestInfo, std::move(msg)); | ||
| TBase::Die(ctx); | ||
| } | ||
|
|
||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| template <typename TRequest, typename TResponse> | ||
| void TTabletActionActor<TRequest, TResponse>::HandleResponse( | ||
| const TResponse::TPtr& ev, | ||
| const TActorContext& ctx) | ||
| { | ||
| ReplyAndDie(ctx, ev->Get()->Record); | ||
| } | ||
|
|
||
| } // namespace | ||
|
|
||
| IActorPtr TStorageServiceActor::CreateUnsafeDeleteNodeActionActor( | ||
| TRequestInfoPtr requestInfo, | ||
| TString input) | ||
| { | ||
| using TUnsafeDeleteNodeActor = TTabletActionActor< | ||
| TEvIndexTablet::TEvUnsafeDeleteNodeRequest, | ||
| TEvIndexTablet::TEvUnsafeDeleteNodeResponse>; | ||
| return std::make_unique<TUnsafeDeleteNodeActor>( | ||
| std::move(requestInfo), | ||
| std::move(input)); | ||
| } | ||
|
|
||
| IActorPtr TStorageServiceActor::CreateUnsafeUpdateNodeActionActor( | ||
| TRequestInfoPtr requestInfo, | ||
| TString input) | ||
| { | ||
| using TUnsafeUpdateNodeActor = TTabletActionActor< | ||
| TEvIndexTablet::TEvUnsafeUpdateNodeRequest, | ||
| TEvIndexTablet::TEvUnsafeUpdateNodeResponse>; | ||
| return std::make_unique<TUnsafeUpdateNodeActor>( | ||
| std::move(requestInfo), | ||
| std::move(input)); | ||
| } | ||
|
|
||
| IActorPtr TStorageServiceActor::CreateUnsafeGetNodeActionActor( | ||
| TRequestInfoPtr requestInfo, | ||
| TString input) | ||
| { | ||
| using TUnsafeGetNodeActor = TTabletActionActor< | ||
| TEvIndexTablet::TEvUnsafeGetNodeRequest, | ||
| TEvIndexTablet::TEvUnsafeGetNodeResponse>; | ||
| return std::make_unique<TUnsafeGetNodeActor>( | ||
| std::move(requestInfo), | ||
| std::move(input)); | ||
| } | ||
|
|
||
| } // namespace NCloud::NFileStore::NStorage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.