blockstore SDK should not retry E_TRY_AGAIN (#2154)

ydb-platform · Sep 29, 2024 · 8cc58f7 · 8cc58f7
1 parent 78fb98b
commit 8cc58f7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cloud/blockstore/public/sdk/go/client/error.go b/cloud/blockstore/public/sdk/go/client/error.go
@@ -38,8 +38,9 @@ func (e *ClientError) Error() string {
 
 func (e *ClientError) IsRetriable() bool {
 	switch e.Code {
-	case E_REJECTED, E_TIMEOUT, E_THROTTLED, E_TRY_AGAIN, E_OUT_OF_SPACE:
+	case E_REJECTED, E_TIMEOUT, E_THROTTLED, E_OUT_OF_SPACE:
 		// special error code for retries
+		// NOTE: do not add E_TRY_AGAIN here - it is not retriable for a reason
 		return true
 	}
 

diff --git a/cloud/blockstore/public/sdk/python/client/error.py b/cloud/blockstore/public/sdk/python/client/error.py
@@ -54,11 +54,11 @@ def from_grpc_error(rpc_error: grpc.RpcError):
     @property
     def is_retriable(self) -> bool:
         # special error code for retries
+        # NOTE: do not add E_TRY_AGAIN here - it is not retriable for a reason
         if self.code in [
             EResult.E_REJECTED.value,
             EResult.E_TIMEOUT.value,
             EResult.E_THROTTLED.value,
-            EResult.E_TRY_AGAIN.value,
             EResult.E_OUT_OF_SPACE.value,
         ]:
             return True