Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide GTIN field for new installs make readonly for existing installs #2622

Open
wants to merge 20 commits into
base: add/support-core-gtin-field
Choose a base branch
from

Tweak tests

d677d3d
Select commit
Loading
Failed to load commit list.
Open

Hide GTIN field for new installs make readonly for existing installs #2622

Tweak tests
d677d3d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 6, 2024 in 1s

65.4% (+0.6%) compared to 2c8f6d2

View this Pull Request on Codecov

65.4% (+0.6%) compared to 2c8f6d2

Details

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.4%. Comparing base (2c8f6d2) to head (d677d3d).
Report is 5 commits behind head on add/support-core-gtin-field.

Files with missing lines Patch % Lines
src/Admin/Product/Attributes/Input/GTINInput.php 88.9% 1 Missing ⚠️
src/Internal/InstallTimestamp.php 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##             add/support-core-gtin-field   #2622     +/-   ##
===============================================================
+ Coverage                           64.7%   65.4%   +0.6%     
- Complexity                          4596    4608     +12     
===============================================================
  Files                                793     474    -319     
  Lines                              22970   17927   -5043     
  Branches                            1231       0   -1231     
===============================================================
- Hits                               14868   11716   -3152     
+ Misses                              7929    6211   -1718     
+ Partials                             173       0    -173     
Files with missing lines Coverage Δ
src/Admin/Input/Input.php 100.0% <100.0%> (ø)
src/Admin/Product/Attributes/AttributesForm.php 97.3% <100.0%> (+<0.1%) ⬆️
src/Admin/Product/Attributes/Input/GTINInput.php 92.9% <88.9%> (-7.1%) ⬇️
src/Internal/InstallTimestamp.php 0.0% <0.0%> (ø)

... and 319 files with indirect coverage changes