-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide GTIN
field for new installs make readonly for existing installs
#2622
Open
martynmjones
wants to merge
20
commits into
add/support-core-gtin-field
Choose a base branch
from
update/2615-hide-gtin-for-new-users-make-readonly-for-exisitng
base: add/support-core-gtin-field
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hide GTIN
field for new installs make readonly for existing installs
#2622
martynmjones
wants to merge
20
commits into
add/support-core-gtin-field
from
update/2615-hide-gtin-for-new-users-make-readonly-for-exisitng
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed and what version of WC is installed
github-actions
bot
added
the
changelog: update
Big changes to something that wasn't broken.
label
Sep 20, 2024
martynmjones
changed the base branch from
develop
to
add/support-core-gtin-field
September 23, 2024 18:02
puntope
reviewed
Sep 25, 2024
puntope
reviewed
Sep 25, 2024
puntope
reviewed
Sep 25, 2024
puntope
reviewed
Sep 25, 2024
…readonly-for-exisitng
…-for-new-users-make-readonly-for-exisitng
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## add/support-core-gtin-field #2622 +/- ##
===============================================================
+ Coverage 64.7% 65.4% +0.6%
- Complexity 4596 4608 +12
===============================================================
Files 793 474 -319
Lines 22970 17927 -5043
Branches 1231 0 -1231
===============================================================
- Hits 14868 11716 -3152
+ Misses 7929 6211 -1718
+ Partials 173 0 -173
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Adds restrictions to the
GTIN
field in Google for WooCommerce depending on the version of WooCommerce installed and what version of Google for WooCommerce was first installed.The following conditions apply:
9.2.0
or higher is installed and Google for WooCommerce is installed for the first time theGTIN
field in G4W is hidden9.2.0
or higher is installed and Google for WooCommerce had already been installed on a website then theGTIN
field in G4W is read-only9.2.0
is installed then theGTIN
field in G4W continues to function as it previously didAdditionally, a new option is added called
INSTALL_VERSION
for tracking what version of Google for WooCommerce was first installed on a website 43a76c3.Closes #2615
Screenshots:
Detailed test instructions:
update/2615-hide-gtin-for-new-users-make-readonly-for-exisitng
on a site with WC9.1.0
installed that has already onboarded with Google for WooCommerceGTIN
field is available on theGoogle for WooCommerce
tab9.2.0
or higherGTIN
field is read-only and the tooltip directs merchants to theInventory
tabwp option update gla_install_version 2.8.4
GTIN
field is not displayed on theGoogle for WooCommerce
tab when editing a productChangelog entry