Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard page and layout #94

Merged
merged 3 commits into from
Jul 11, 2023
Merged

dashboard page and layout #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbb335d
dashboard page and layout
luka0009 Jul 11, 2023
17d7c1e
Merge branch 'webdevcody:main' into main
luka0009 Jul 11, 2023
8347148
Merge branch 'webdevcody:main' into main
luka0009 Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/app/dashboard/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export default function DashboardLayout({
children,
}: {
children: React.ReactNode;
}) {
return <div className="overflow-x-hidden overflow-y-clip md:pb-28">{children}</div>;
}
10 changes: 5 additions & 5 deletions src/app/dashboard/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export default function DashboardPage() {
Dashboard
</h1>
<div className="flex max-[600px]:flex-col justify-center items-center w-screen h-[55vh] gap-6 m-2">
<Card className="w-[47.5%] max-[600px]:w-[100%] max-[600px]:mr-4 h-full max-[600px]:h-[50%]">
<Card className="w-[45.5%] max-[600px]:w-[100%] max-[600px]:mr-4 h-full max-[600px]:h-[50%]">
<CardHeader>
<CardTitle className="text-center m-2">Accuracy</CardTitle>
</CardHeader>
Expand All @@ -119,7 +119,7 @@ export default function DashboardPage() {
</LineChart>
</ResponsiveContainer>
</Card>
<Card className="w-[47.5%] max-[600px]:w-[100%] h-full max-[600px]:h-[50%] max-[600px]:mr-4 max-[600px]:ml-4 max-[600px]:mb-6">
<Card className="w-[45.5%] max-[600px]:w-[100%] h-full max-[600px]:h-[50%] max-[600px]:mr-4 max-[600px]:ml-4 max-[600px]:mb-6">
<CardHeader>
<CardTitle className="text-center m-2">Words per minute</CardTitle>
</CardHeader>
Expand All @@ -144,11 +144,11 @@ export default function DashboardPage() {
</Card>
</div>
<div className="flex max-[850px]:flex-col justify-center items-center w-screen min-[850px]:h-[55vh] gap-4 m-4">
<Card className="w-[55vw] max-[850px]:w-[100vw] min-[850px]:h-[55vh] mr-4 p-4">
<Card className="w-[50vw] max-[850px]:w-[100vw] min-[850px]:h-[55vh] mr-4 p-4 border-none">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Border none doesnt give a clear indication of how big the card is.

<CardHeader>
<CardTitle className="text-center m-2">Recent Races</CardTitle>
</CardHeader>
<Table className="w-full max-[600px]:text-sm">
<Table className="w-full max-[600px]:text-sm border-b-2">
<TableHeader>
<TableRow>
<TableHead className="max-[900px]:hidden">Game ID</TableHead>
Expand Down Expand Up @@ -209,7 +209,7 @@ export default function DashboardPage() {
</Button>
</div>
</Card>
<Card className="w-[40vw] max-[850px]:w-screen min-[850px]:h-[55vh] mr-4">
<Card className="w-[42vw] max-[850px]:w-screen min-[850px]:h-[50vh] mr-4 border-none">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

55vh looks better imo since the recent games card has 55vh as height.

<CardHeader>
<CardTitle className="text-center m-2">Statistics</CardTitle>
</CardHeader>
Expand Down