dashboard page and layout #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @webdevcody on Vercel. @webdevcody first needs to authorize it. |
Killbyfire
reviewed
Jul 11, 2023
| @@ -148,11 +148,11 @@ export default function DashboardPage() { | |||
| </Card> | |||
| </div> | |||
| <div className="flex max-[850px]:flex-col justify-center items-center w-screen min-[850px]:h-[55vh] gap-4 m-4"> | |||
| <Card className="w-[55vw] max-[850px]:w-[100vw] min-[850px]:h-[55vh] mr-4 p-4"> | |||
| <Card className="w-[50vw] max-[850px]:w-[100vw] min-[850px]:h-[55vh] mr-4 p-4 border-none"> | |||
There was a problem hiding this comment.
Border none doesnt give a clear indication of how big the card is.
Killbyfire
reviewed
Jul 11, 2023
| @@ -213,7 +213,7 @@ export default function DashboardPage() { | |||
| </Button> | |||
| </div> | |||
| </Card> | |||
| <Card className="w-[40vw] max-[850px]:w-screen min-[850px]:h-[55vh] mr-4"> | |||
| <Card className="w-[42vw] max-[850px]:w-screen min-[850px]:h-[50vh] mr-4 border-none"> | |||
There was a problem hiding this comment.
55vh looks better imo since the recent games card has 55vh as height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: Issue #93
I fixed the dashboard page, I added a layout for the page and corrected footer and horiznotal scroll. I also fixed bottom tables, since they also had overflowed content and didn't have good UI.
Discord Username: @luka#10
What type of PR is this? (select all that apply)
Description
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
UI accessibility concerns?
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?