Skip to content

Commit

Permalink
Fix Typos in Docs (#7283)
Browse files Browse the repository at this point in the history
* Fix Link to Contributing Guide

Closes #7266

* Fix Wrong Param Name in Web3Modal Docs

Replaces #7275
  • Loading branch information
danforbes authored Sep 23, 2024
1 parent 6f9a485 commit d6baee6
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ yarn add web3
## Migration Guide

- [Migration Guide from Web3.js 1.x to 4.x](https://docs.web3js.org/guides/web3_upgrade_guide/x/)
Breaking changes are listed in migration guide and its first step for migrating from Web3.js 1.x to 4.x. If there is any question or discussion feel free to ask in [Discord](https://discord.gg/yjyvFRP), and in case of any bug or new feature request [open issue](https://github.com/web3/web3.js/issues/new) or create a pull request for [contributions](https://github.com/web3/web3.js/blob/4.x/CONTRIBUTIONS.md).
Breaking changes are listed in migration guide and its first step for migrating from Web3.js 1.x to 4.x. If there is any question or discussion feel free to ask in [Discord](https://discord.gg/yjyvFRP), and in case of any bug or new feature request [open issue](https://github.com/web3/web3.js/issues/new) or create a pull request for [contributions](https://github.com/web3/web3.js/blob/4.x/.github/CONTRIBUTING.md).

## Useful links

Expand Down
2 changes: 1 addition & 1 deletion docs/docs/guides/wallet/web3_modal_guide/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const web3Config = defaultConfig({

// 5. Create a Web3Modal instance
createWeb3Modal({
ethersConfig,
web3Config,
chains: [mainnet],
projectId,
enableAnalytics: true // Optional - defaults to your Cloud configuration
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/guides/wallet/web3_modal_guide/react.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const web3Config = defaultConfig({

// 5. Create a Web3Modal instance
createWeb3Modal({
ethersConfig,
web3Config,
chains: [mainnet],
projectId,
enableAnalytics: true // Optional - defaults to your Cloud configuration
Expand Down
2 changes: 1 addition & 1 deletion packages/web3/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ yarn add web3
## Migration Guide

- [Migration Guide from Web3.js 1.x to 4.x](https://docs.web3js.org/docs/guides/web3_migration_guide)
Breaking changes are listed in migration guide and its first step for migrating from Web3.js 1.x to 4.x. If there is any question or discussion feel free to ask in discord, and in case of any bug or new feature request [open issue](https://github.com/web3/web3.js/issues/new) or create a pull request for [contributions](https://github.com/web3/web3.js/blob/4.x/CONTRIBUTIONS.md).
Breaking changes are listed in migration guide and its first step for migrating from Web3.js 1.x to 4.x. If there is any question or discussion feel free to ask in discord, and in case of any bug or new feature request [open issue](https://github.com/web3/web3.js/issues/new) or create a pull request for [contributions](https://github.com/web3/web3.js/blob/4.x/.github/CONTRIBUTING.md).

## Package.json Scripts

Expand Down

1 comment on commit d6baee6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d6baee6 Previous: 6f9a485 Ratio
processingTx 20672 ops/sec (±7.40%) 21688 ops/sec (±8.58%) 1.05
processingContractDeploy 39409 ops/sec (±5.84%) 38621 ops/sec (±6.70%) 0.98
processingContractMethodSend 14911 ops/sec (±8.22%) 15698 ops/sec (±6.99%) 1.05
processingContractMethodCall 26166 ops/sec (±9.05%) 28405 ops/sec (±6.07%) 1.09
abiEncode 41338 ops/sec (±7.20%) 42626 ops/sec (±7.39%) 1.03
abiDecode 29000 ops/sec (±6.11%) 29174 ops/sec (±8.52%) 1.01
sign 1518 ops/sec (±3.68%) 1502 ops/sec (±3.88%) 0.99
verify 365 ops/sec (±0.65%) 364 ops/sec (±0.56%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.