Skip to content

Commit

Permalink
Fix CHANGELOG for PR 7239 (#7271)
Browse files Browse the repository at this point in the history
* Fix CHANGELOG for PR 7239

* Update web3 CHANGELOG
  • Loading branch information
danforbes authored Sep 19, 2024
1 parent 5a7e302 commit 6f9a485
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2724,7 +2724,7 @@ If there are any bugs, improvements, optimizations or any new feature proposal f

#### web3

- `Web3.providers` namespace exports `type EIP6963ProviderResponse = Map<string, EIP6963ProviderDetail>`. Return type for the static `Web3.requestEIP6963Providers` is now `Promise<EIP6963ProviderResponse>`. (#7239)
- Return type for the static `Web3.requestEIP6963Providers` function is now `Promise<EIP6963ProviderResponse>`. (#7239)
- The callback function provided to the static `Web3.onNewProviderDiscovered` function expects a parameter of type `EIP6963ProvidersMapUpdateEvent` as opposed to `EIP6963AnnounceProviderEvent`. (#7242)

## [Unreleased]
2 changes: 1 addition & 1 deletion packages/web3/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ Documentation:

### Changed

- `Web3.providers` namespace exports `type EIP6963ProviderResponse = Map<string, EIP6963ProviderDetail>`. Return type for the static `Web3.requestEIP6963Providers` is now `Promise<EIP6963ProviderResponse>`. (#7239)
- Return type for the static `Web3.requestEIP6963Providers` function is now `Promise<EIP6963ProviderResponse>`. (#7239)
- The callback function provided to the static `Web3.onNewProviderDiscovered` function expects a parameter of type `EIP6963ProvidersMapUpdateEvent` as opposed to `EIP6963AnnounceProviderEvent`. (#7242)

## [Unreleased]

1 comment on commit 6f9a485

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 6f9a485 Previous: 5a7e302 Ratio
processingTx 21688 ops/sec (±8.58%) 22309 ops/sec (±7.22%) 1.03
processingContractDeploy 38621 ops/sec (±6.70%) 40363 ops/sec (±6.95%) 1.05
processingContractMethodSend 15698 ops/sec (±6.99%) 16570 ops/sec (±7.02%) 1.06
processingContractMethodCall 28405 ops/sec (±6.07%) 28034 ops/sec (±6.73%) 0.99
abiEncode 42626 ops/sec (±7.39%) 44249 ops/sec (±8.56%) 1.04
abiDecode 29174 ops/sec (±8.52%) 32311 ops/sec (±5.75%) 1.11
sign 1502 ops/sec (±3.88%) 1547 ops/sec (±3.62%) 1.03
verify 364 ops/sec (±0.56%) 367 ops/sec (±0.54%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.